Wasmtime GitHub notifications bot (Feb 09 2021 at 23:47): Wasmtime GitHub notifications bot (Feb 09 2021 at 23:47):pchickey opened PR #2649 from pch/fix_wasi_libc_opendir to main:
the fdstat of a dirfd needs to include both the file and dir rights in
the inheriting field.The wasi-libc path_open bases the base rights of child directories off
the inheriting rights of the parent, so if we only put file rights in
there, opening a child directory will not have any directory operations
permitted.Fixes https://github.com/bytecodealliance/wasmtime/issues/2638
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 09 2021 at 23:57):pchickey requested sunfishcode for a review on PR #2649.
Wasmtime GitHub notifications bot (Feb 11 2021 at 00:53):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Feb 11 2021 at 00:53):sunfishcode merged PR #2649.
Last updated: Dec 23 2024 at 12:05 UTC