Stream: git-wasmtime

Topic: wasmtime / PR #2614 Avoid creating 0-sized nops in x64's ...

Wasmtime GitHub notifications bot (Jan 28 2021 at 07:07):

kaseyc opened PR #2614 from nop to main:

By contract, the result of gen_nop() must be nonzero:
https://github.com/bytecodealliance/wasmtime/blob/503129ad9103028cd0b56ae969848ec1bbf25bc7/cranelift/codegen/src/machinst/mod.rs#L181

Otherwise. emit could get stuck in an infinite loop.

This should not change generated code at all since all generated instructions will still be 1-15 bytes.

Wasmtime GitHub notifications bot (Jan 28 2021 at 07:55):

kaseyc updated PR #2614 from nop to main:

By contract, the result of gen_nop() must be nonzero:
https://github.com/bytecodealliance/wasmtime/blob/503129ad9103028cd0b56ae969848ec1bbf25bc7/cranelift/codegen/src/machinst/mod.rs#L181

Otherwise. emit could get stuck in an infinite loop.

This should not change generated code at all since all generated instructions will still be 1-15 bytes.

Wasmtime GitHub notifications bot (Jan 29 2021 at 04:47):

kaseyc updated PR #2614 from nop to main:

By contract, the result of gen_nop() must be nonzero:
https://github.com/bytecodealliance/wasmtime/blob/503129ad9103028cd0b56ae969848ec1bbf25bc7/cranelift/codegen/src/machinst/mod.rs#L181

Otherwise. emit could get stuck in an infinite loop.

This should not change generated code at all since all generated instructions will still be 1-15 bytes.

Wasmtime GitHub notifications bot (Jan 29 2021 at 05:37):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Jan 29 2021 at 05:37):

cfallin merged PR #2614.

Last updated: Dec 23 2024 at 13:07 UTC