bjorn3 opened PR #2600 from remove_some_riscv_test_uses
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bjorn3 updated PR #2600 from remove_some_riscv_test_uses
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
nit: popcnt
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
Is it intended to mark this test as ignored, or did you plan to look into it? It's not obvious where the error is here; did you get a relevant backtrace or something that would help diagnose what's going on?
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
It just fails to parse the test. I don't know why. This test was already effectively ignored previously as cranelift-reader doesn't have a riscv feature.
bjorn3 updated PR #2600 from remove_some_riscv_test_uses
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
target x86_64
bnjbvr created PR Review Comment:
bnjbvr created PR Review Comment:
//! isa_builder.set("use_popcnt", "on");
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
assert_eq!(v[0].name(), "x86");
bnjbvr updated PR #2600 from remove_some_riscv_test_uses
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
#[cfg(not(feature = "experimental_x64"))] assert_eq!(v[0].name(), "x86"); #[cfg(feature = "experimental_x64")] assert_eq!(v[0].name(), "x64");
bnjbvr updated PR #2600 from remove_some_riscv_test_uses
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bnjbvr merged PR #2600.
Last updated: Dec 23 2024 at 13:07 UTC