Wasmtime GitHub notifications bot (Jan 23 2021 at 18:49): Wasmtime GitHub notifications bot (Jan 23 2021 at 18:49):bjorn3 opened PR #2600 from remove_some_riscv_test_uses to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 24 2021 at 09:25):bjorn3 updated PR #2600 from remove_some_riscv_test_uses to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 29 2021 at 13:14):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jan 29 2021 at 13:14):bnjbvr created PR Review Comment:
nit: popcnt
Wasmtime GitHub notifications bot (Jan 29 2021 at 13:14):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jan 29 2021 at 13:14):bnjbvr created PR Review Comment:
Is it intended to mark this test as ignored, or did you plan to look into it? It's not obvious where the error is here; did you get a relevant backtrace or something that would help diagnose what's going on?
Wasmtime GitHub notifications bot (Jan 29 2021 at 14:05):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 29 2021 at 14:05):bjorn3 created PR Review Comment:
It just fails to parse the test. I don't know why. This test was already effectively ignored previously as cranelift-reader doesn't have a riscv feature.
Wasmtime GitHub notifications bot (Jan 29 2021 at 14:06):bjorn3 updated PR #2600 from remove_some_riscv_test_uses to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr created PR Review Comment:
target x86_64
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr created PR Review Comment:
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr created PR Review Comment:
//! isa_builder.set("use_popcnt", "on");
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr created PR Review Comment:
assert_eq!(v[0].name(), "x86");
Wasmtime GitHub notifications bot (Jan 30 2021 at 17:58):bnjbvr updated PR #2600 from remove_some_riscv_test_uses to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 30 2021 at 18:14):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jan 30 2021 at 18:14):bnjbvr created PR Review Comment:
#[cfg(not(feature = "experimental_x64"))] assert_eq!(v[0].name(), "x86"); #[cfg(feature = "experimental_x64")] assert_eq!(v[0].name(), "x64");
Wasmtime GitHub notifications bot (Jan 30 2021 at 18:14):bnjbvr updated PR #2600 from remove_some_riscv_test_uses to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 30 2021 at 22:54):bnjbvr merged PR #2600.
Last updated: Oct 23 2024 at 20:03 UTC