Stream: git-wasmtime

Topic: wasmtime / PR #2599 bench-api: Allow access to files in t...

Wasmtime GitHub notifications bot (Jan 23 2021 at 01:32):

fitzgen opened PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 23 2021 at 01:32):

fitzgen requested abrown for a review on PR #2599.

Wasmtime GitHub notifications bot (Jan 25 2021 at 17:14):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 17:14):

abrown created PR Review Comment:

Not sure this is correct: if we run the benchmarks from the sightglass root directory, we would preopen that instead of benchmarks-next/[some benchmark] (which is what I thought we wanted to do). Unfortunately, to preopen benchmarks-next/[some benchmark] we probably need to pass a path in--the path to the Wasm file would work--or alter the current directory before running each benchmark.

Wasmtime GitHub notifications bot (Jan 25 2021 at 17:15):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 17:15):

abrown created PR Review Comment:

Is there a way to pass along WASM_BENCH_*?

Wasmtime GitHub notifications bot (Jan 25 2021 at 17:15):

abrown edited PR Review Comment.

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:35):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:35):

fitzgen created PR Review Comment:

I think it makes sense to only pass through explicitly allowed env vars just so that there are less moving parts and fewer unknowns / potential ways to bias our measurements.

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:36):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:36):

fitzgen created PR Review Comment:

This is running in benchmarks-next/$name because the in-process benchmark command is spawned with the correct current directory set

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:37):

fitzgen updated PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:47):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:47):

abrown created PR Review Comment:

Cool; should we document that here?

Wasmtime GitHub notifications bot (Jan 25 2021 at 18:47):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:38):

fitzgen updated PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:38):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:38):

fitzgen created PR Review Comment:

Added a comment

Wasmtime GitHub notifications bot (Jan 25 2021 at 21:52):

fitzgen updated PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 25 2021 at 22:21):

fitzgen updated PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 26 2021 at 00:31):

peterhuene created PR Review Comment:

If you use wasi_common::preopen_dir it'll handle the Windows-specific logic to make this work.

Wasmtime GitHub notifications bot (Jan 26 2021 at 00:31):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Jan 26 2021 at 00:31):

peterhuene edited PR Review Comment.

Wasmtime GitHub notifications bot (Jan 26 2021 at 17:43):

fitzgen updated PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 26 2021 at 17:43):

fitzgen created PR Review Comment:

Thanks!

Wasmtime GitHub notifications bot (Jan 26 2021 at 17:43):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 26 2021 at 17:44):

fitzgen updated PR #2599 from bench-api-files-env-vars to main:

And pass through the WASM_BENCH_USE_SMALL_WORKLOAD env var.

Part of https://github.com/bytecodealliance/sightglass/issues/70

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 26 2021 at 18:35):

fitzgen merged PR #2599.

Last updated: Nov 22 2024 at 17:03 UTC