fitzgen opened PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen requested abrown for a review on PR #2599.
abrown submitted PR Review.
abrown created PR Review Comment:
Not sure this is correct: if we run the benchmarks from the sightglass root directory, we would preopen that instead of
benchmarks-next/[some benchmark]
(which is what I thought we wanted to do). Unfortunately, to preopenbenchmarks-next/[some benchmark]
we probably need to pass a path in--the path to the Wasm file would work--or alter the current directory before running each benchmark.
abrown submitted PR Review.
abrown created PR Review Comment:
Is there a way to pass along
WASM_BENCH_*
?
abrown edited PR Review Comment.
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
I think it makes sense to only pass through explicitly allowed env vars just so that there are less moving parts and fewer unknowns / potential ways to bias our measurements.
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
This is running in
benchmarks-next/$name
because the in-process benchmark command is spawned with the correct current directory set
fitzgen updated PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
abrown submitted PR Review.
abrown created PR Review Comment:
Cool; should we document that here?
abrown submitted PR Review.
fitzgen updated PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
Added a comment
fitzgen updated PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen updated PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
peterhuene created PR Review Comment:
If you use
wasi_common::preopen_dir
it'll handle the Windows-specific logic to make this work.
peterhuene submitted PR Review.
peterhuene edited PR Review Comment.
fitzgen updated PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen created PR Review Comment:
Thanks!
fitzgen submitted PR Review.
fitzgen updated PR #2599 from bench-api-files-env-vars
to main
:
And pass through the
WASM_BENCH_USE_SMALL_WORKLOAD
env var.Part of https://github.com/bytecodealliance/sightglass/issues/70
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen merged PR #2599.
Last updated: Dec 23 2024 at 12:05 UTC