Stream: git-wasmtime

Topic: wasmtime / PR #2596 Refactor instantiation to be more asy...

Wasmtime GitHub notifications bot (Jan 21 2021 at 20:19):

alexcrichton opened PR #2596 from refactor-instantiation to main:

Instantiation right now uses a recursive instantiate function since it
was relatively easy to write that way, but this is unfortunately not
factored in a way friendly to the async implementation in #2434. This
commit refactors the function to instead use an iterative loop and
refactors code in such a way that it should be easy to rebase #2434 on
top of this change. The main goal is to make the body of Instance::new
as small as possible since it needs to be duplicated with
Instance::new_async.

Wasmtime GitHub notifications bot (Jan 21 2021 at 20:20):

alexcrichton updated PR #2596 from refactor-instantiation to main:

Instantiation right now uses a recursive instantiate function since it
was relatively easy to write that way, but this is unfortunately not
factored in a way friendly to the async implementation in #2434. This
commit refactors the function to instead use an iterative loop and
refactors code in such a way that it should be easy to rebase #2434 on
top of this change. The main goal is to make the body of Instance::new
as small as possible since it needs to be duplicated with
Instance::new_async.

Wasmtime GitHub notifications bot (Jan 21 2021 at 20:23):

alexcrichton updated PR #2596 from refactor-instantiation to main:

Instantiation right now uses a recursive instantiate function since it
was relatively easy to write that way, but this is unfortunately not
factored in a way friendly to the async implementation in #2434. This
commit refactors the function to instead use an iterative loop and
refactors code in such a way that it should be easy to rebase #2434 on
top of this change. The main goal is to make the body of Instance::new
as small as possible since it needs to be duplicated with
Instance::new_async.

Wasmtime GitHub notifications bot (Jan 21 2021 at 20:31):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Jan 21 2021 at 21:04):

alexcrichton merged PR #2596.

Last updated: Dec 23 2024 at 13:07 UTC