Stream: git-wasmtime

Topic: wasmtime / PR #2579 Update WebAssembly C API submodule to...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2021 at 21:31):

peterhuene opened PR #2579 from update-c-api to main:

This PR updates the WebAssembly C API submodule (for wasm.h) to the
latest commit out of master.

This fixes the behavior of wasm_name_new_from_string such that it no longer
copies the null character into the name, which caused unexpected failures when
using the Wasmtime linker as imports wouldn't resolve when the null was
present.

Along with this change were breaking changes to wasm_func_call, the host
callback signatures, and wasm_instance_new to take a vector type instead of a
pointer to an unsized array.

As a result, Wasmtime language bindings based on the C API will need to be
updated once this change is pulled in.

Fixes #2211.
Fixes #2131.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2021 at 21:31):

peterhuene requested alexcrichton for a review on PR #2579.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2021 at 21:56):

peterhuene updated PR #2579 from update-c-api to main:

This PR updates the WebAssembly C API submodule (for wasm.h) to the
latest commit out of master.

This fixes the behavior of wasm_name_new_from_string such that it no longer
copies the null character into the name, which caused unexpected failures when
using the Wasmtime linker as imports wouldn't resolve when the null was
present.

Along with this change were breaking changes to wasm_func_call, the host
callback signatures, and wasm_instance_new to take a vector type instead of a
pointer to an unsized array.

As a result, Wasmtime language bindings based on the C API will need to be
updated once this change is pulled in.

Fixes #2211.
Fixes #2131.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2021 at 21:56):

peterhuene updated PR #2579 from update-c-api to main:

This PR updates the WebAssembly C API submodule (for wasm.h) to the
latest commit out of master.

This fixes the behavior of wasm_name_new_from_string such that it no longer
copies the null character into the name, which caused unexpected failures when
using the Wasmtime linker as imports wouldn't resolve when the null was
present.

Along with this change were breaking changes to wasm_func_call, the host
callback signatures, and wasm_instance_new to take a vector type instead of a
pointer to an unsized array.

As a result, Wasmtime language bindings based on the C API will need to be
updated once this change is pulled in.

Fixes #2211.
Fixes #2131.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2021 at 15:36):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2021 at 15:36):

alexcrichton merged PR #2579.


Last updated: Nov 22 2024 at 17:03 UTC