Wasmtime GitHub notifications bot (Jan 12 2021 at 21:56): Wasmtime GitHub notifications bot (Jan 12 2021 at 21:56):jedisct1 opened PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 06:21):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 06:21):bjorn3 created PR Review Comment:
./spec/...?
Wasmtime GitHub notifications bot (Jan 13 2021 at 08:25):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 08:26):jedisct1 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 08:26):jedisct1 created PR Review Comment:
Sure! The relative path has been changed, thanks!
Wasmtime GitHub notifications bot (Jan 13 2021 at 10:10):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 10:42):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 11:40):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:15):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:15):alexcrichton created PR Review Comment:
I'm a little worried about this myself,
wiggleisn't super stable in its interface an APIs, and I think we'd like to reserve the right to change them at any time. If a bundled dependency in a submodule (e.g. the wasmtime integration in the wasi-crypto repository) useswiggleas defined in-tree then we won't be able to change the one in-tree if it breaks wasi-crypto.Would it be possible to have the wiggle integration live in this repository instead of the wasi-crypto repository? Ideally the integration in the wasi-crypto repository would only depend on non-wasmtime crates on crates.io so we can be sure that changes in wasmtime won't accidentally break it.
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:15):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:15):alexcrichton created PR Review Comment:
Instead of using
canonicalizeyou can useenv::current_dir().join("spec")to geet an absolute path heere I believe.
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:15):alexcrichton created PR Review Comment:
This path seems a bit odd, but since it's crate relative I think everything before
speccan be dropped?
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:57):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:57):jedisct1 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:57):jedisct1 created PR Review Comment:
Absolutely. Done! Thank you!
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:58):jedisct1 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 15:58):jedisct1 created PR Review Comment:
Changed to
env::current_dir(). Thanks!
Wasmtime GitHub notifications bot (Jan 13 2021 at 16:00):jedisct1 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 16:00):jedisct1 created PR Review Comment:
The implementation has been moved to this repository. It indeed only depends on non-wasmtime crates beyond
wiggle, so that should be fine.Thank you!
Wasmtime GitHub notifications bot (Jan 13 2021 at 19:20):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Jan 13 2021 at 22:04):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 13 2021 at 22:43):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 19 2021 at 16:36):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jan 19 2021 at 16:36):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jan 19 2021 at 16:36):alexcrichton created PR Review Comment:
Hm so ideally we only have one
Cargo.lockin the root of the repository, but if one is showing up here is the workspace perehaps misconfigured?
Wasmtime GitHub notifications bot (Jan 19 2021 at 18:41):jedisct1 updated PR #2573 from wasmtime-crypto to main:
This adds support for the experimental [wasi-crypto] APIs.
The sole purpose of the implementation is to allow bindings and application developers to test the proposed APIs. Rust and AssemblyScript bindings are also available as examples.
Like
wasi-nn, it is currently disabled by default, and requires thewasi-cryptofeature flag to be compiled in.[wasi-crypto]: https://github.com/WebAssembly/wasi-crypto
Wasmtime GitHub notifications bot (Jan 19 2021 at 18:41):jedisct1 submitted PR Review.
Wasmtime GitHub notifications bot (Jan 19 2021 at 18:41):jedisct1 created PR Review Comment:
Removed, thanks!
Wasmtime GitHub notifications bot (Jan 19 2021 at 19:05):jedisct1 closed without merge PR #2573.
Last updated: Nov 22 2024 at 17:03 UTC