Stream: git-wasmtime

Topic: wasmtime / PR #2570 wiggle: generate flags using `bitflags`

Wasmtime GitHub notifications bot (Jan 12 2021 at 02:31):

pchickey opened PR #2570 from pch/wiggle_flags_bitflags to main:

Wiggle generated flags that were sorta kinda like the ones generated by bitflags::bitflags!. The biggest stumbling block is that, for whatever reason, fn contains(&self, &Self) -> bool took the rhs by reference instead of value, despite deriving Copy.

For API consistency with the rest of the ecosystem, and to throw away some code, implement Wiggle's flags code generation using bitflags::bitflags!.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 12 2021 at 02:31):

pchickey requested alexcrichton for a review on PR #2570.

Wasmtime GitHub notifications bot (Jan 12 2021 at 14:46):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jan 12 2021 at 17:51):

pchickey updated PR #2570 from pch/wiggle_flags_bitflags to main:

Wiggle generated flags that were sorta kinda like the ones generated by bitflags::bitflags!. The biggest stumbling block is that, for whatever reason, fn contains(&self, &Self) -> bool took the rhs by reference instead of value, despite deriving Copy.

For API consistency with the rest of the ecosystem, and to throw away some code, implement Wiggle's flags code generation using bitflags::bitflags!.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 12 2021 at 21:48):

pchickey merged PR #2570.

Last updated: Oct 23 2024 at 20:03 UTC