Stream: git-wasmtime

Topic: wasmtime / PR #2559 wasm->CLIF: fn translate_operator: Se...

Wasmtime GitHub notifications bot (Jan 08 2021 at 10:51):

julian-seward1 opened PR #2559 from wasm-bitcast-vector-select to main:

…tcasts

The translation of Operator::Select and Operator::TypedSelect for vector-typed
operands, lacks the relevant bitcasting of the operands to I8X16. This commit
adds it.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 08 2021 at 11:41):

julian-seward1 requested yurydelendik for a review on PR #2559.

Wasmtime GitHub notifications bot (Jan 08 2021 at 14:38):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jan 11 2021 at 10:15):

julian-seward1 updated PR #2559 from wasm-bitcast-vector-select to main:

…tcasts

The translation of Operator::Select and Operator::TypedSelect for vector-typed
operands, lacks the relevant bitcasting of the operands to I8X16. This commit
adds it.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 11 2021 at 10:59):

julian-seward1 merged PR #2559.

Last updated: Nov 22 2024 at 16:03 UTC