Stream: git-wasmtime

Topic: wasmtime / PR #2549 wasmtime-wiggle: missing memory can j...

Wasmtime GitHub notifications bot (Jan 06 2021 at 01:33):

pchickey opened PR #2549 from pch/wiggle_missing_memory_is_trap to main:

The missing memory behavior was always a silly thing that was created long ago because I didn't understand the wasmtime API very well. Instead of creating a weird warning and returning an error code to the caller wasm, we now return a Err(Trap::new("missing memory")) to wasmtime to handle this error case.

Users will need to remove the missing_memory field from their invocation of wasmtime_wiggle::wasmtime_integration!.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 06 2021 at 01:45):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jan 06 2021 at 19:01):

pchickey updated PR #2549 from pch/wiggle_missing_memory_is_trap to main:

The missing memory behavior was always a silly thing that was created long ago because I didn't understand the wasmtime API very well. Instead of creating a weird warning and returning an error code to the caller wasm, we now return a Err(Trap::new("missing memory")) to wasmtime to handle this error case.

Users will need to remove the missing_memory field from their invocation of wasmtime_wiggle::wasmtime_integration!.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 06 2021 at 19:40):

pchickey merged PR #2549.

Last updated: Nov 22 2024 at 16:03 UTC