Stream: git-wasmtime

Topic: wasmtime / PR #2535 use wencoder for dummy instead of wat

Wasmtime GitHub notifications bot (Dec 30 2020 at 06:49):

misapprehand opened PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 15 2021 at 12:50):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 15 2021 at 13:01):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 15 2021 at 13:10):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 22 2021 at 19:12):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 22 2021 at 19:12):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 22 2021 at 19:12):

fitzgen created PR Review Comment:

Nothing is using the WAT versions anymore, right? So we should be able to remove them and the WatGenerator and also just name dummy_module_wenc as dummy_module instead of having the latter wrap the former.

Wasmtime GitHub notifications bot (Jan 22 2021 at 19:12):

fitzgen created PR Review Comment:

If ExternType::Func is ever provided more than once, then this will define multiple types, functions, and codes sections, but each section must only appear once in a Wasm binary. Similar for other methods. Rather than defining the sections inside this method, and adding them to the module at the end of it, I think the WencoderGenerator should have self.types, self.functions, etc members that have each section, and then finish would add them to self.module in the correct order before calling self.module.finish().

Wasmtime GitHub notifications bot (Jan 23 2021 at 08:46):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 23 2021 at 10:09):

misapprehand submitted PR Review.

Wasmtime GitHub notifications bot (Jan 23 2021 at 10:09):

misapprehand created PR Review Comment:

@fitzgen I update the PR. There is one question. I cannot find instruction section in correct order. So I did not add it to module. Is it right?

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:33):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:33):

fitzgen created PR Review Comment:

This needs to use the type's index, rather than hard code 0.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:33):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:33):

fitzgen created PR Review Comment:

This should be a module with the given module type, not an empty module. This method should create a new module and add the import and export types to that new module's types/imports/exports/etc sections, not the current module's sections.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:33):

fitzgen created PR Review Comment:

These comments were fine before, and the new versions are less informative, so let's revert the doc comment changes here and elsewhere.

Wasmtime GitHub notifications bot (Jan 25 2021 at 20:33):

fitzgen created PR Review Comment:

We don't need to create a local binding to self.module_section here, we could just do

self.module_section.module(...);

Similar for other sections.

Wasmtime GitHub notifications bot (Jan 28 2021 at 12:52):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 29 2021 at 13:11):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 03 2021 at 07:55):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 03 2021 at 08:54):

misapprehand updated PR #2535 from fix_2498 to main:

1. extract wat generator to other file
2. add wencoder generator
3. splite wat genrator and wencoder to different function in dummy.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 14 2024 at 17:53):

alexcrichton closed without merge PR #2535.

Wasmtime GitHub notifications bot (Mar 14 2024 at 17:53):

alexcrichton commented on PR #2535:

This is pretty out of date now at this point so I'm going to close this. I think the change would still be good to have though!

Last updated: Dec 23 2024 at 12:05 UTC