Stream: git-wasmtime

Topic: wasmtime / PR #2527 Add serde serialization support for t...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 19 2020 at 15:40):

bjorn3 opened PR #2527 from serialize_ir to main:

This is necessary to embed clif ir in object files for external tools to consume without unreasonable overhead. It would probably also make it much quicker to serialize clif ir to files than writing it in textual format. This would be useful during development of cg_clif.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 19 2020 at 15:40):

bjorn3 edited PR #2527 from serialize_ir to main:

This is necessary to embed clif ir in object files for external tools to consume without unreasonable overhead. It would probably also make it much quicker to serialize clif ir to files than writing it in textual format. This would be useful during development of cg_clif. (cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/710)

view this post on Zulip Wasmtime GitHub notifications bot (Dec 19 2020 at 15:53):

bjorn3 updated PR #2527 from serialize_ir to main:

This is necessary to embed clif ir in object files for external tools to consume without unreasonable overhead. It would probably also make it much quicker to serialize clif ir to files than writing it in textual format. This would be useful during development of cg_clif. (cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/710)

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2021 at 10:49):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2021 at 10:51):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2021 at 11:05):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2021 at 02:16):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2021 at 02:16):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2021 at 02:16):

cfallin created PR Review Comment:

Can you say a bit more about why we need a custom Serialize/Deserialize for Layout? This sort of code can be somewhat error-prone, especially when we update it later (with footguns such as silently forgetting to include a field we have added). At the very least, if we have to implement it this way, we should document the serialized sequence (it looks like a series of blocknum, inst_count, [insts] elements?) and add warning comments in Layout to note that only certain data is serialized.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2021 at 07:07):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 09 2021 at 07:07):

bjorn3 created PR Review Comment:

Layout uses linked lists of blocks and instructions. In addition each block and inst has a sequence number that monotonically increases. This wastes a lot of space. I replaced it with a list of blocks and block sizes followed by a list of instructions.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2021 at 00:08):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2021 at 00:08):

cfallin created PR Review Comment:

OK, that's sort of what I expected -- makes sense. Could you add a detailed doc comment that describes the equivalent serialized data structure (list of elements of these types ...)?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2021 at 10:09):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2021 at 10:09):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2021 at 10:09):

bjorn3 created PR Review Comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 18:01):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 18:04):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 18:10):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 10:28):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 11:16):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 11:50):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 12:01):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 12:53):

bjorn3 updated PR #2527 from serialize_ir to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 16:33):

cfallin merged PR #2527.

Last updated: Dec 23 2024 at 12:05 UTC