Wasmtime GitHub notifications bot (Dec 18 2020 at 13:11): Wasmtime GitHub notifications bot (Dec 18 2020 at 13:11):sakarias88 opened PR #2523 from add-fstat-std-tests to main:
Adding tests as discussed in issue #2515.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 14 2021 at 13:39):simonrainerson updated PR #2523 from add-fstat-std-tests to main:
Adding tests as discussed in issue #2515.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 14 2021 at 13:58):simonrainerson updated PR #2523 from add-fstat-std-tests to main:
Adding tests as discussed in issue #2515.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 14 2021 at 15:18):simonrainerson updated PR #2523 from add-fstat-std-tests to main:
Adding tests as discussed in issue #2515.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 14 2021 at 16:22):simonrainerson updated PR #2523 from add-fstat-std-tests to main:
Adding tests as discussed in issue #2515.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):alexcrichton closed without merge PR #2523.
Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):alexcrichton commented on PR #2523:
This is pretty dated at this point so I'm going to close this. Lots about WASI has additionally changed in the intervening time. To the extent that it's nice to have more tests I think it'd still be good to add tests for this, but that's probably best done in a fresh PR.
Last updated: Oct 23 2024 at 20:03 UTC