Stream: git-wasmtime

Topic: wasmtime / PR #2520 Prune deps, comment deny.toml

Wasmtime GitHub notifications bot (Dec 17 2020 at 19:06):

pchickey opened PR #2520 from pch/prune_deps to main:

Follow up on #2519

1. Run cargo update to get the latest deps.
2. Eliminate a dep on an old wasmparser by turning off cargo features we weren't using.
3. Comment on all skipped duplicate deps on why they are an issue.

The duplicate deps fall into two categories:

1. transitive deps pull in different versions. Some stuff, like cfg-if and env_logger, are so popular that it would be very hard to motivate the whole rust ecosystem to use the very latest.
2. frequently-updated crates we maintain use, like wasmparser and wast, are used directly and also transitively via dependencies which live in other repos. It would create toil to keep these consistent all the time. We can put occasional effort into keeping these updated, but it isn't worth being perfect.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 17 2020 at 19:13):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Dec 17 2020 at 19:13):

alexcrichton created PR Review Comment:

With the dependency through object we should control all the dependencies on wasmparser, so I think this should be fixable by updating everything in-tree to 0.71?

Wasmtime GitHub notifications bot (Dec 17 2020 at 19:14):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Dec 17 2020 at 19:14):

bjorn3 created PR Review Comment:

    { name = "env_logger" }, # pretty_env_logger and file-per-thread-logger depend on 0.7

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:26):

pchickey updated PR #2520 from pch/prune_deps to main:

Follow up on #2519

1. Run cargo update to get the latest deps.
2. Eliminate a dep on an old wasmparser by turning off cargo features we weren't using.
3. Comment on all skipped duplicate deps on why they are an issue.

The duplicate deps fall into two categories:

1. transitive deps pull in different versions. Some stuff, like cfg-if and env_logger, are so popular that it would be very hard to motivate the whole rust ecosystem to use the very latest.
2. frequently-updated crates we maintain use, like wasmparser and wast, are used directly and also transitively via dependencies which live in other repos. It would create toil to keep these consistent all the time. We can put occasional effort into keeping these updated, but it isn't worth being perfect.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:26):

pchickey updated PR #2520 from pch/prune_deps to main:

Follow up on #2519

1. Run cargo update to get the latest deps.
2. Eliminate a dep on an old wasmparser by turning off cargo features we weren't using.
3. Comment on all skipped duplicate deps on why they are an issue.

The duplicate deps fall into two categories:

1. transitive deps pull in different versions. Some stuff, like cfg-if and env_logger, are so popular that it would be very hard to motivate the whole rust ecosystem to use the very latest.
2. frequently-updated crates we maintain use, like wasmparser and wast, are used directly and also transitively via dependencies which live in other repos. It would create toil to keep these consistent all the time. We can put occasional effort into keeping these updated, but it isn't worth being perfect.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:51):

pchickey updated PR #2520 from pch/prune_deps to main:

Follow up on #2519

1. Run cargo update to get the latest deps.
2. Eliminate a dep on an old wasmparser by turning off cargo features we weren't using.
3. Comment on all skipped duplicate deps on why they are an issue.

The duplicate deps fall into two categories:

1. transitive deps pull in different versions. Some stuff, like cfg-if and env_logger, are so popular that it would be very hard to motivate the whole rust ecosystem to use the very latest.
2. frequently-updated crates we maintain use, like wasmparser and wast, are used directly and also transitively via dependencies which live in other repos. It would create toil to keep these consistent all the time. We can put occasional effort into keeping these updated, but it isn't worth being perfect.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:51):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:51):

pchickey created PR Review Comment:

Fixed fb78025

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:52):

pchickey edited PR #2520 from pch/prune_deps to main:

Follow up on #2519

1. Run cargo update to get the latest deps.
2. Eliminate a dep on an old wasmparser by turning off cargo features we weren't using.
3. Comment on all skipped duplicate deps on why they are an issue.
4. Upgrade to wasmparser 0.71 in tree. Leave some new simd instructions as wasm_unsupported! in cranelift-wasm.

The duplicate deps fall into two categories:

1. transitive deps pull in different versions. Some stuff, like cfg-if and env_logger, are so popular that it would be very hard to motivate the whole rust ecosystem to use the very latest.
2. frequently-updated crates we maintain use, like wasmparser and wast, are used directly and also transitively via dependencies which live in other repos. It would create toil to keep these consistent all the time. We can put occasional effort into keeping these updated, but it isn't worth being perfect.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:52):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:52):

pchickey created PR Review Comment:

Note: had to leave some new simd instructions as wasm_unsupported! in cranelift-wasm.

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:53):

pchickey updated PR #2520 from pch/prune_deps to main:

Follow up on #2519

1. Run cargo update to get the latest deps.
2. Eliminate a dep on an old wasmparser by turning off cargo features we weren't using.
3. Comment on all skipped duplicate deps on why they are an issue.
4. Upgrade to wasmparser 0.71 in tree. Leave some new simd instructions as wasm_unsupported! in cranelift-wasm.

The duplicate deps fall into two categories:

1. transitive deps pull in different versions. Some stuff, like cfg-if and env_logger, are so popular that it would be very hard to motivate the whole rust ecosystem to use the very latest.
2. frequently-updated crates we maintain use, like wasmparser and wast, are used directly and also transitively via dependencies which live in other repos. It would create toil to keep these consistent all the time. We can put occasional effort into keeping these updated, but it isn't worth being perfect.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 17 2020 at 22:53):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Dec 17 2020 at 23:33):

pchickey merged PR #2520.

Last updated: Dec 23 2024 at 12:05 UTC