Wasmtime GitHub notifications bot (Dec 17 2020 at 02:54): Wasmtime GitHub notifications bot (Dec 17 2020 at 02:54):cfallin opened PR #2517 from fix-null-byte-symbols to main:
Avoid a
panic!(), and return a proper error, on a NUL byte. We hit a
null-byte check inside theobjectcrate otherwise; this blocks fuzzing
when testing via a write-object-file-and-dlopen flow.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 17 2020 at 02:54):cfallin requested alexcrichton and abrown for a review on PR #2517.
Wasmtime GitHub notifications bot (Dec 17 2020 at 02:54):cfallin requested alexcrichton and abrown for a review on PR #2517.
Wasmtime GitHub notifications bot (Dec 17 2020 at 15:06):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Dec 17 2020 at 15:06):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Dec 17 2020 at 15:06):alexcrichton created PR Review Comment:
It might be better to use
:?here which will show the nul byte perhaps?
Wasmtime GitHub notifications bot (Dec 17 2020 at 17:39):cfallin updated PR #2517 from fix-null-byte-symbols to main:
Avoid a
panic!(), and return a proper error, on a NUL byte. We hit a
null-byte check inside theobjectcrate otherwise; this blocks fuzzing
when testing via a write-object-file-and-dlopen flow.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 17 2020 at 17:41):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Dec 17 2020 at 17:41):cfallin created PR Review Comment:
Done.
Wasmtime GitHub notifications bot (Dec 17 2020 at 17:54):cfallin updated PR #2517 from fix-null-byte-symbols to main:
Avoid a
panic!(), and return a proper error, on a NUL byte. We hit a
null-byte check inside theobjectcrate otherwise; this blocks fuzzing
when testing via a write-object-file-and-dlopen flow.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 17 2020 at 18:33):cfallin merged PR #2517.
Last updated: Dec 23 2024 at 12:05 UTC