Wasmtime GitHub notifications bot (Dec 15 2020 at 19:24): Wasmtime GitHub notifications bot (Dec 15 2020 at 19:24):fitzgen opened PR #2512 from bench-api-tweaks to main:
Mostly just tweaks to docs/naming/readability/tidying up.
The biggest thing is that the wasm bytes are passed in during compilation now,
rather than on initialization, which lets us remove the lifetime from our state
struct and makes wrangling unsafe conversions that much easier.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 15 2020 at 19:24):fitzgen requested abrown for a review on PR #2512.
Wasmtime GitHub notifications bot (Dec 15 2020 at 19:31):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Dec 15 2020 at 20:18):fitzgen merged PR #2512.
Last updated: Dec 23 2024 at 12:05 UTC