Wasmtime GitHub notifications bot (Dec 15 2020 at 05:56): Wasmtime GitHub notifications bot (Dec 15 2020 at 05:56):jlb6740 opened PR #2510 from implement_x64_simd_loads to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 15 2020 at 05:56):jlb6740 requested cfallin for a review on PR #2510.
Wasmtime GitHub notifications bot (Dec 15 2020 at 05:56):jlb6740 assigned PR #2510 to abrown.
Wasmtime GitHub notifications bot (Dec 15 2020 at 05:56):jlb6740 unassigned PR #2510.
Wasmtime GitHub notifications bot (Dec 15 2020 at 05:56):jlb6740 requested cfallin and abrown for a review on PR #2510.
Wasmtime GitHub notifications bot (Dec 16 2020 at 20:49):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Dec 16 2020 at 20:49):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Dec 16 2020 at 20:49):cfallin created PR Review Comment:
Leftover debugging printlns (here and a few below)?
Wasmtime GitHub notifications bot (Dec 16 2020 at 22:31):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Dec 16 2020 at 22:31):jlb6740 created PR Review Comment:
@cfallin So sorry. I could I have sworn I removed those in the latest push. Ok, Thanks.
Wasmtime GitHub notifications bot (Dec 16 2020 at 22:34):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Dec 16 2020 at 22:34):jlb6740 created PR Review Comment:
@cfallin @abrown Also not sure what we are doing? Is it ok to merge this or do we need to wait for #2432? I did run this against the spec tests and passed no problem, but of course there is a intermittent spec test problem with certain SIMD float instructions that we need to resolve before turning those tests back on.
Wasmtime GitHub notifications bot (Dec 16 2020 at 23:03):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Dec 16 2020 at 23:03):cfallin created PR Review Comment:
@jlb6740 Thanks! IMHO, it might be better to merge this now, just in order to have one less outstanding PR to keep track of, and given that everything passes fine for you locally; when we eventually turn the tests back on, after finding the intermittent bug, we will know right away if this has somehow broken in the meantime.
Wasmtime GitHub notifications bot (Dec 16 2020 at 23:45):jlb6740 updated PR #2510 from implement_x64_simd_loads to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 17 2020 at 01:13):jlb6740 merged PR #2510.
Wasmtime GitHub notifications bot (Dec 17 2020 at 16:46):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Dec 17 2020 at 16:46):abrown created PR Review Comment:
I guess we should merge #2480 and #2489 then? I'll rebase them and take them out of draft mode... they're just sitting there getting stale right now.
Last updated: Oct 23 2024 at 20:03 UTC