Stream: git-wasmtime

Topic: wasmtime / PR #2501 WIP (#2499): First pass on TableOps f...

Wasmtime GitHub notifications bot (Dec 12 2020 at 06:19):

dhaynespls opened PR #2501 from dhaynespls/2499-tableops-to-wasm-encoder to main:

This PR migrates the TableOps fuzzer generator from the old string concatenation strategy to utilizing wasm_encoder to generate a wasm binary for us.

Tests updated accordingly.

Closes #2499

Wasmtime GitHub notifications bot (Dec 12 2020 at 06:23):

dhaynespls submitted PR Review.

Wasmtime GitHub notifications bot (Dec 12 2020 at 06:23):

dhaynespls created PR Review Comment:

oops -- should be WAT

Wasmtime GitHub notifications bot (Dec 12 2020 at 06:24):

dhaynespls submitted PR Review.

Wasmtime GitHub notifications bot (Dec 12 2020 at 06:24):

dhaynespls created PR Review Comment:

unused import

Wasmtime GitHub notifications bot (Dec 14 2020 at 16:21):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Dec 14 2020 at 16:21):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Dec 14 2020 at 16:21):

alexcrichton created PR Review Comment:

Since this is a type index I think you'll need to define the type with a TypeSection as well.

Wasmtime GitHub notifications bot (Dec 14 2020 at 16:21):

alexcrichton created PR Review Comment:

One option here is that instead of to_instruction this could be something like insert(&self, func: &mut Function) and that way you can insert multiple functions if necessary.

Wasmtime GitHub notifications bot (Dec 14 2020 at 16:21):

alexcrichton created PR Review Comment:

If this is unused now feel free to delete!

Wasmtime GitHub notifications bot (Dec 14 2020 at 16:21):

alexcrichton created PR Review Comment:

The return type of this function will probably want to change to Vec<u8> since a string is no longer constructed.

Wasmtime GitHub notifications bot (Dec 14 2020 at 18:28):

dhaynespls updated PR #2501 from dhaynespls/2499-tableops-to-wasm-encoder to main:

This PR migrates the TableOps fuzzer generator from the old string concatenation strategy to utilizing wasm_encoder to generate a wasm binary for us.

Tests updated accordingly.

Closes #2499

Wasmtime GitHub notifications bot (Dec 14 2020 at 18:29):

dhaynespls submitted PR Review.

Wasmtime GitHub notifications bot (Dec 14 2020 at 18:29):

dhaynespls created PR Review Comment:

This is a great idea -- I took a stab at it!

Wasmtime GitHub notifications bot (Dec 14 2020 at 18:29):

dhaynespls submitted PR Review.

Wasmtime GitHub notifications bot (Dec 14 2020 at 18:29):

dhaynespls created PR Review Comment:

Added! Though not sure if it's right.

Wasmtime GitHub notifications bot (Dec 14 2020 at 18:29):

dhaynespls has marked PR #2501 as ready for review.

Last updated: Nov 22 2024 at 17:03 UTC