dhaynespls opened PR #2501 from dhaynespls/2499-tableops-to-wasm-encoder
to main
:
This PR migrates the TableOps fuzzer generator from the old string concatenation strategy to utilizing
wasm_encoder
to generate a wasm binary for us.Tests updated accordingly.
Closes #2499
dhaynespls submitted PR Review.
dhaynespls created PR Review Comment:
oops -- should be
WAT
dhaynespls submitted PR Review.
dhaynespls created PR Review Comment:
unused import
alexcrichton submitted PR Review.
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
Since this is a type index I think you'll need to define the type with a
TypeSection
as well.
alexcrichton created PR Review Comment:
One option here is that instead of
to_instruction
this could be something likeinsert(&self, func: &mut Function)
and that way you can insert multiple functions if necessary.
alexcrichton created PR Review Comment:
If this is unused now feel free to delete!
alexcrichton created PR Review Comment:
The return type of this function will probably want to change to
Vec<u8>
since a string is no longer constructed.
dhaynespls updated PR #2501 from dhaynespls/2499-tableops-to-wasm-encoder
to main
:
This PR migrates the TableOps fuzzer generator from the old string concatenation strategy to utilizing
wasm_encoder
to generate a wasm binary for us.Tests updated accordingly.
Closes #2499
dhaynespls submitted PR Review.
dhaynespls created PR Review Comment:
This is a great idea -- I took a stab at it!
dhaynespls submitted PR Review.
dhaynespls created PR Review Comment:
Added! Though not sure if it's right.
dhaynespls has marked PR #2501 as ready for review.
Last updated: Dec 23 2024 at 12:05 UTC