Stream: git-wasmtime

Topic: wasmtime / PR #2497 Enable fuzzing the module linking imp...

Wasmtime GitHub notifications bot (Dec 11 2020 at 16:38):

alexcrichton opened PR #2497 from fuzz-module-linking to main:

This commit updates all the wasm-tools crates that we use and enables
fuzzing of the module linking proposal in our various fuzz targets. This
also refactors some of the dummy value generation logic to not be
fallible and to always succeed, the thinking being that we don't want to
accidentally hide errors while fuzzing. Additionally instantiation is
only allowed to fail with a Trap, other failure reasons are unwrapped.

Wasmtime GitHub notifications bot (Dec 11 2020 at 16:38):

alexcrichton requested fitzgen for a review on PR #2497.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:45):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:45):

fitzgen created PR Review Comment:

This doesn't seem a ton easier than using wasm-encoder directly. Want to file a follow up issue that we can mark good-first-issue for some contributor to replace this with wasm-encoder? Would help us get a little bit more fuzzing throughput here.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:45):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:46):

fitzgen merged PR #2497.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:46):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:46):

fitzgen created PR Review Comment:

I guess I can just file it, since there was nothing else for me to nitpick before this merged :-p

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:53):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Dec 11 2020 at 17:53):

alexcrichton created PR Review Comment:

Oh heh good point!

Last updated: Dec 23 2024 at 13:07 UTC