Stream: git-wasmtime

Topic: wasmtime / PR #2496 Fix iconst.i8 0 miscompilation with o...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 16:19):

bjorn3 opened PR #2496 from fix_iconst_i8_0_miscompilation to main:

This fixes the cg_clif miscompilation I wrote about at https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/miscompilation.20with.20opt_level.3Dspeed_and_size/near/219461997 when using opt_level=speed_and_size. See https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/miscompilation.20with.20opt_level.3Dspeed_and_size/near/219596956 for the root problem this fixes.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 17:12):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 17:12):

abrown created PR Review Comment:

    // safely drop the 0x66 prefix, so we explicitly select a wider but permissible opcode.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 17:14):

bjorn3 updated PR #2496 from fix_iconst_i8_0_miscompilation to main:

This fixes the cg_clif miscompilation I wrote about at https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/miscompilation.20with.20opt_level.3Dspeed_and_size/near/219461997 when using opt_level=speed_and_size. See https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/miscompilation.20with.20opt_level.3Dspeed_and_size/near/219596956 for the root problem this fixes.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 17:15):

bjorn3 updated PR #2496 from fix_iconst_i8_0_miscompilation to main:

This fixes the cg_clif miscompilation I wrote about at https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/miscompilation.20with.20opt_level.3Dspeed_and_size/near/219461997 when using opt_level=speed_and_size. See https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/miscompilation.20with.20opt_level.3Dspeed_and_size/near/219596956 for the root problem this fixes.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 17:32):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2020 at 17:32):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2020 at 08:43):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2020 at 08:44):

bnjbvr merged PR #2496.

Last updated: Dec 23 2024 at 13:07 UTC