Stream: git-wasmtime

Topic: wasmtime / PR #2482 Fix `branch_destination_mut()` access...

Wasmtime GitHub notifications bot (Dec 06 2020 at 02:09):

cfallin requested alexcrichton and fitzgen for a review on PR #2482.

Wasmtime GitHub notifications bot (Dec 06 2020 at 02:09):

cfallin opened PR #2482 from fix-indirect-br-branch-dest-accessor to main:

Found via fuzzing: the branch_destination_mut() accessor on
InstructionData was missing a case for IndirectJump. As per the
doc-comment, this should return None. Note that the match in
branch_destination() does have IndirectJump in the analogous place;
this appears to just have been an oversight.

Adding an LICM test from the fuzzer (minimized) because this is how it
was triggered; it's somewhat difficult to write a more direct test than
this.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 06 2020 at 02:09):

cfallin requested alexcrichton and fitzgen for a review on PR #2482.

Wasmtime GitHub notifications bot (Dec 07 2020 at 08:04):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Dec 07 2020 at 17:26):

cfallin closed without merge PR #2482.

Last updated: Nov 22 2024 at 16:03 UTC