Stream: git-wasmtime

Topic: wasmtime / PR #2478 aarch64 isel: collect_address_addends...

Wasmtime GitHub notifications bot (Dec 04 2020 at 17:41):

julian-seward1 opened PR #2478 from fix-collect-address-addends to main:

…TW(negative immediate)`.

The current code doesn't correctly handle the case where ExtendOp::UXTW has
as source, a constant-producing insn that produces a negative (32-bit) value.
Then the value is incorrectly sign-extended to 64 bits (in fact, this has
already been done by ctx.get_constant(insn)), whereas it needs to be zero
extended. The obvious fix, done here, is just to force bits 63:32 of the
extension to zero, hence zero-extending it.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 04 2020 at 17:42):

julian-seward1 requested cfallin for a review on PR #2478.

Wasmtime GitHub notifications bot (Dec 04 2020 at 17:47):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Dec 04 2020 at 18:21):

julian-seward1 merged PR #2478.

Last updated: Dec 23 2024 at 12:05 UTC