Stream: git-wasmtime

Topic: wasmtime / PR #2472 Update the C API with module linking ...

Wasmtime GitHub notifications bot (Dec 03 2020 at 19:17):

alexcrichton opened PR #2472 from module-linking-c-api to main:

This commit does everything necessary (ideally) to support the module
linking proposal in the C API. The changes here are:

• New wasm_{module,instance}type_t types and accessors
• New wasm_{module,instance}_type functions

• Conversions between wasm_extern_t and wasm_{instance,module}_t, as
  well as wasm_externtype_t and the new types.

• Addition of WASM_EXTERN_{MODULE,INSTANCE} constants

• New wasm_config_t modifier to enable/disable module linking

With these functions it should be possible to pass instances/modules to
instances and also acquire them from exports. Altogether this should
enable everything for module linking.

An important point for this is that I've opted to add all these items
under the wasm_* name prefix instead of wasmtime_*. I've done this
since they're all following the idioms of existing APIs and while not
standard the intention would be to standardize them (unlike many other
Wasmtime-specific APIs).

cc #2094

Wasmtime GitHub notifications bot (Dec 03 2020 at 19:17):

alexcrichton requested peterhuene for a review on PR #2472.

Wasmtime GitHub notifications bot (Dec 03 2020 at 19:33):

alexcrichton updated PR #2472 from module-linking-c-api to main:

This commit does everything necessary (ideally) to support the module
linking proposal in the C API. The changes here are:

• New wasm_{module,instance}type_t types and accessors
• New wasm_{module,instance}_type functions

• Conversions between wasm_extern_t and wasm_{instance,module}_t, as
  well as wasm_externtype_t and the new types.

• Addition of WASM_EXTERN_{MODULE,INSTANCE} constants

• New wasm_config_t modifier to enable/disable module linking

With these functions it should be possible to pass instances/modules to
instances and also acquire them from exports. Altogether this should
enable everything for module linking.

An important point for this is that I've opted to add all these items
under the wasm_* name prefix instead of wasmtime_*. I've done this
since they're all following the idioms of existing APIs and while not
standard the intention would be to standardize them (unlike many other
Wasmtime-specific APIs).

cc #2094

Wasmtime GitHub notifications bot (Dec 03 2020 at 21:13):

alexcrichton updated PR #2472 from module-linking-c-api to main:

This commit does everything necessary (ideally) to support the module
linking proposal in the C API. The changes here are:

• New wasm_{module,instance}type_t types and accessors
• New wasm_{module,instance}_type functions

• Conversions between wasm_extern_t and wasm_{instance,module}_t, as
  well as wasm_externtype_t and the new types.

• Addition of WASM_EXTERN_{MODULE,INSTANCE} constants

• New wasm_config_t modifier to enable/disable module linking

With these functions it should be possible to pass instances/modules to
instances and also acquire them from exports. Altogether this should
enable everything for module linking.

An important point for this is that I've opted to add all these items
under the wasm_* name prefix instead of wasmtime_*. I've done this
since they're all following the idioms of existing APIs and while not
standard the intention would be to standardize them (unlike many other
Wasmtime-specific APIs).

cc #2094

Wasmtime GitHub notifications bot (Dec 03 2020 at 21:48):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Dec 03 2020 at 21:51):

alexcrichton merged PR #2472.

Last updated: Dec 23 2024 at 12:05 UTC