Stream: git-wasmtime

Topic: wasmtime / PR #2466 Fix module-linking handling of instan...

Wasmtime GitHub notifications bot (Dec 02 2020 at 20:14):

alexcrichton opened PR #2466 from fix-subtyping-orders to main:

When we alias the nth export of an instance, due to subtyping the nth
export may not actually be what we want. Instead we need to look at our
local type definition's nth export's name, and lookup that name off the
export.

Wasmtime GitHub notifications bot (Dec 03 2020 at 16:16):

alexcrichton updated PR #2466 from fix-subtyping-orders to main:

When we alias the nth export of an instance, due to subtyping the nth
export may not actually be what we want. Instead we need to look at our
local type definition's nth export's name, and lookup that name off the
export.

Wasmtime GitHub notifications bot (Dec 03 2020 at 16:16):

alexcrichton requested peterhuene for a review on PR #2466.

Wasmtime GitHub notifications bot (Dec 03 2020 at 18:46):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Dec 03 2020 at 18:46):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Dec 03 2020 at 18:46):

peterhuene created PR Review Comment:

GitHub needs a wee lil' nit emoji:

            // Here we lookup our instance handle, find the right export,

Wasmtime GitHub notifications bot (Dec 03 2020 at 19:41):

alexcrichton updated PR #2466 from fix-subtyping-orders to main:

When we alias the nth export of an instance, due to subtyping the nth
export may not actually be what we want. Instead we need to look at our
local type definition's nth export's name, and lookup that name off the
export.

Wasmtime GitHub notifications bot (Dec 03 2020 at 19:41):

alexcrichton merged PR #2466.

Last updated: Oct 23 2024 at 20:03 UTC