Wasmtime GitHub notifications bot (Dec 02 2020 at 01:04): Wasmtime GitHub notifications bot (Dec 02 2020 at 01:04):cfallin opened PR #2462 from fix-sorted-debug-addr-transform to main:
This issue was found while fuzzing the new backend (#2453); I suspect
that it arises with the new backend because we can sink instructions
(e.g. loads or extends) in more interesting ways than before, but I'm
not entirely sure.Test coverage will be via the fuzz corpus once #2453 lands.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 02 2020 at 01:04):cfallin requested yurydelendik for a review on PR #2462.
Wasmtime GitHub notifications bot (Dec 02 2020 at 08:25):cfallin updated PR #2462 from fix-sorted-debug-addr-transform to main:
This issue was found while fuzzing the new backend (#2453); I suspect
that it arises with the new backend because we can sink instructions
(e.g. loads or extends) in more interesting ways than before, but I'm
not entirely sure.Test coverage will be via the fuzz corpus once #2453 lands.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 02 2020 at 08:26):cfallin edited PR #2462 from fix-sorted-debug-addr-transform to main:
Sort by generated-code offset to maintain invariant and avoid gimli
panic.Fix srcloc interaction with branch peephole optimization in
MachBuffer: if a srcloc range overlaps with a branch that is
truncated, remove that srcloc range.These issues were found while fuzzing the new backend (#2453); I suspect
that they arise with the new backend because we can sink instructions
(e.g. loads or extends) in more interesting ways than before, but I'm
not entirely sure.Test coverage will be via the fuzz corpus once #2453 lands.
Last updated: Nov 22 2024 at 17:03 UTC