Stream: git-wasmtime

Topic: wasmtime / PR #2460 interpreter: fix confusion caused by ...

Wasmtime GitHub notifications bot (Dec 01 2020 at 02:15):

abrown requested fitzgen for a review on PR #2460.

Wasmtime GitHub notifications bot (Dec 01 2020 at 02:15):

abrown opened PR #2460 from fix-function-store to main:

Prior to this change, the interpreter would use an incorrect FuncRef for accessing functions from the function store. This is now clarified and fixed by a new type--FuncIndex.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2020 at 17:36):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Dec 01 2020 at 17:36):

fitzgen merged PR #2460.

Last updated: Dec 23 2024 at 12:05 UTC