Wasmtime GitHub notifications bot (Nov 25 2020 at 02:58): Wasmtime GitHub notifications bot (Nov 25 2020 at 02:58):cfallin opened PR #2450 from cfallin/fix-wasm-reachable to main:
This makes the value of
state.reachable()inaccurate when observing at
the tail of functions (in the post-function hook) after an ordinary
return instruction.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 25 2020 at 02:58):cfallin requested fitzgen for a review on PR #2450.
Wasmtime GitHub notifications bot (Nov 25 2020 at 17:20):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Nov 25 2020 at 18:56):cfallin updated PR #2450 from cfallin/fix-wasm-reachable to main:
This makes the value of
state.reachable()inaccurate when observing at
the tail of functions (in the post-function hook) after an ordinary
return instruction.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 25 2020 at 18:58):cfallin requested fitzgen for a review on PR #2450.
Wasmtime GitHub notifications bot (Nov 25 2020 at 21:08):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Nov 25 2020 at 21:09):fitzgen merged PR #2450.
Last updated: Nov 22 2024 at 16:03 UTC