Stream: git-wasmtime

Topic: wasmtime / PR #2449 Add FuncEnvironment hooks to generate...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 25 2020 at 00:26):

cfallin requested fitzgen and iximeow for a review on PR #2449.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 25 2020 at 00:26):

cfallin opened PR #2449 from cfallin/add-pre-host-hooks to main:

In some cases, it is useful to do some work at entry to or exit from a
Cranelift function translated from WebAssembly. This PR adds two
optional methods to the FuncEnvironment trait to do just this,
analogous to the pre/post-hooks on operators that already exist.

This PR also includes a drive-by compilation fix due to the latest
nightly wherein .is_empty() on a Range ambiguously refers to either
the Range impl or the ExactSizeIterator impl and can't resolve.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 25 2020 at 00:26):

cfallin requested fitzgen and iximeow for a review on PR #2449.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 25 2020 at 00:38):

cfallin updated PR #2449 from cfallin/add-pre-host-hooks to main:

In some cases, it is useful to do some work at entry to or exit from a
Cranelift function translated from WebAssembly. This PR adds two
optional methods to the FuncEnvironment trait to do just this,
analogous to the pre/post-hooks on operators that already exist.

This PR also includes a drive-by compilation fix due to the latest
nightly wherein .is_empty() on a Range ambiguously refers to either
the Range impl or the ExactSizeIterator impl and can't resolve.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 25 2020 at 01:48):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 25 2020 at 01:48):

fitzgen merged PR #2449.


Last updated: Dec 23 2024 at 12:05 UTC