Stream: git-wasmtime

Topic: wasmtime / PR #2449 Add FuncEnvironment hooks to generate...

Wasmtime GitHub notifications bot (Nov 25 2020 at 00:26):

cfallin requested fitzgen and iximeow for a review on PR #2449.

Wasmtime GitHub notifications bot (Nov 25 2020 at 00:26):

cfallin opened PR #2449 from cfallin/add-pre-host-hooks to main:

In some cases, it is useful to do some work at entry to or exit from a
Cranelift function translated from WebAssembly. This PR adds two
optional methods to the FuncEnvironment trait to do just this,
analogous to the pre/post-hooks on operators that already exist.

This PR also includes a drive-by compilation fix due to the latest
nightly wherein .is_empty() on a Range ambiguously refers to either
the Range impl or the ExactSizeIterator impl and can't resolve.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 25 2020 at 00:26):

cfallin requested fitzgen and iximeow for a review on PR #2449.

Wasmtime GitHub notifications bot (Nov 25 2020 at 00:38):

cfallin updated PR #2449 from cfallin/add-pre-host-hooks to main:

In some cases, it is useful to do some work at entry to or exit from a
Cranelift function translated from WebAssembly. This PR adds two
optional methods to the FuncEnvironment trait to do just this,
analogous to the pre/post-hooks on operators that already exist.

This PR also includes a drive-by compilation fix due to the latest
nightly wherein .is_empty() on a Range ambiguously refers to either
the Range impl or the ExactSizeIterator impl and can't resolve.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 25 2020 at 01:48):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Nov 25 2020 at 01:48):

fitzgen merged PR #2449.

Last updated: Nov 22 2024 at 16:03 UTC