Stream: git-wasmtime

Topic: wasmtime / PR #2448 refresh wasi-nn/spec version to an in...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2020 at 23:49):

iximeow opened PR #2448 from ixi/bump-wasi-nn-spec to main:

It looks like the wasi-nn/spec commit that got landed last week references an orphaned form of the spec history - wasi-nn/spec current points to https://github.com/WebAssembly/wasi-nn/commit/68e73cf612eb8671e0c141b107bf1593491bdc16. This change bumps the version to https://github.com/WebAssembly/wasi-nn/commit/793d4cd888ab74e3b7bf018bcc6ab2a2426a1004 which appears to be the same content through to the shared history with 68e73cf, but is available to systems that try to fetch submodule commits through available refs (such as Jenkins :grimacing:)

Also the orphaned commit might get GC'd by github at any point so we probably shouldn't depend on it!

I've checked the three differing commits,

  68e73cf Modify API for wiggle integration
  5d5900b Add wasi-nn specific error and size types
  d4264de Use typename for tensor data and avoid importing ephemeral types

for differences and came up blank, so I assume this was some other rebase with an old commit reference hanging around in a tree? cc @abrown in case this is noteworthy.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2020 at 23:50):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2020 at 00:26):

cfallin merged PR #2448.

Last updated: Nov 22 2024 at 16:03 UTC