Stream: git-wasmtime

Topic: wasmtime / PR #2446 Propagate optional import names to th...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2020 at 23:26):

alexcrichton opened PR #2446 from option-name to main:

With the module linking proposal the field name on imports is now
optional, and only the module is required to be specified. This commit
propagates this API change to the boundary of wasmtime's API, ensuring
consumers are aware of what's optional with module linking and what
isn't. Note that it's expected that all existing users will either
update accordingly or unwrap the result since module linking is
presumably disabled.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2020 at 23:32):

alexcrichton edited PR #2446 from option-name to main:

With the module linking proposal the field name on imports is now
optional, and only the module is required to be specified. This commit
propagates this API change to the boundary of wasmtime's API, ensuring
consumers are aware of what's optional with module linking and what
isn't. Note that it's expected that all existing users will either
update accordingly or unwrap the result since module linking is
presumably disabled.

cc #2094 2094

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2020 at 15:07):

alexcrichton updated PR #2446 from option-name to main:

With the module linking proposal the field name on imports is now
optional, and only the module is required to be specified. This commit
propagates this API change to the boundary of wasmtime's API, ensuring
consumers are aware of what's optional with module linking and what
isn't. Note that it's expected that all existing users will either
update accordingly or unwrap the result since module linking is
presumably disabled.

cc #2094 2094

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2020 at 15:07):

alexcrichton edited PR #2446 from option-name to main:

With the module linking proposal the field name on imports is now
optional, and only the module is required to be specified. This commit
propagates this API change to the boundary of wasmtime's API, ensuring
consumers are aware of what's optional with module linking and what
isn't. Note that it's expected that all existing users will either
update accordingly or unwrap the result since module linking is
presumably disabled.

cc #2094

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2020 at 16:28):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2020 at 16:28):

fitzgen merged PR #2446.


Last updated: Dec 23 2024 at 13:07 UTC