Stream: git-wasmtime

Topic: wasmtime / PR #2440 Adds support for i32x4.trunc_sat_f32x4_u

Wasmtime GitHub notifications bot (Nov 22 2020 at 23:36):

jlb6740 opened PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 23 2020 at 04:58):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 23 2020 at 05:34):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 23 2020 at 06:50):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 23 2020 at 07:50):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 23 2020 at 18:34):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 23 2020 at 21:43):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 24 2020 at 03:02):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 24 2020 at 03:02):

jlb6740 has marked PR #2440 as ready for review.

Wasmtime GitHub notifications bot (Nov 24 2020 at 03:02):

jlb6740 requested bnjbvr for a review on PR #2440.

Wasmtime GitHub notifications bot (Nov 24 2020 at 03:02):

jlb6740 requested abrown for a review on PR #2440.

Wasmtime GitHub notifications bot (Nov 24 2020 at 03:03):

jlb6740 requested abrown and bnjbvr for a review on PR #2440.

Wasmtime GitHub notifications bot (Nov 24 2020 at 03:03):

jlb6740 requested cfallin, abrown and bnjbvr for a review on PR #2440.

Wasmtime GitHub notifications bot (Nov 24 2020 at 08:02):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Nov 24 2020 at 08:02):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Nov 24 2020 at 08:02):

cfallin created PR Review Comment:

This explanation is somewhat hard to follow; I think it would help to write out the expressions for each intermediate result. Perhaps also a table showing values for each of the four cases: negative, 0..INT_MAX, INT_MAX+1..UINT_MAX, above UINT_MAX.

Wasmtime GitHub notifications bot (Nov 24 2020 at 08:02):

cfallin created PR Review Comment:

I just noticed that here and above for FcvtToSintSat we assume I32X4. Is it the case that no other vector lane width will be used with this opcode? If so, can we assert on the input type (e.g., assert_eq!(types::F32X4, ctx.input_ty(insn, 0))?

Wasmtime GitHub notifications bot (Nov 24 2020 at 19:26):

jlb6740 submitted PR Review.

Wasmtime GitHub notifications bot (Nov 24 2020 at 19:26):

jlb6740 created PR Review Comment:

Cool .. good suggestion. I'll make it easier to follow and highlight some specific cases.

Wasmtime GitHub notifications bot (Nov 24 2020 at 19:37):

jlb6740 submitted PR Review.

Wasmtime GitHub notifications bot (Nov 24 2020 at 19:37):

jlb6740 created PR Review Comment:

Good point. I'll point some assertions in.

Wasmtime GitHub notifications bot (Nov 28 2020 at 00:21):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 28 2020 at 00:22):

jlb6740 requested cfallin, abrown and bnjbvr for a review on PR #2440.

Wasmtime GitHub notifications bot (Nov 29 2020 at 00:23):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 29 2020 at 02:04):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 29 2020 at 08:39):

jlb6740 updated PR #2440 from remaining_simd_conversions to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 01 2020 at 06:53):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Dec 01 2020 at 06:54):

cfallin merged PR #2440.

Last updated: Dec 23 2024 at 12:05 UTC