Wasmtime GitHub notifications bot (Nov 16 2020 at 19:06): Wasmtime GitHub notifications bot (Nov 16 2020 at 19:06):alexcrichton opened PR #2423 from document-wasi-proposals to main:
I've attempted to summarize our thoughts from last week's meeting here
to jot down the suggested guidelines for adding a new WASI proposal to
this repository. I've also filled it out a bit with the two proposals we
support at this time.
Wasmtime GitHub notifications bot (Nov 16 2020 at 19:17):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Nov 18 2020 at 15:30):tschneidereit submitted PR Review.
Wasmtime GitHub notifications bot (Nov 18 2020 at 15:30):tschneidereit submitted PR Review.
Wasmtime GitHub notifications bot (Nov 18 2020 at 15:30):tschneidereit created PR Review Comment:
Nit: "relataively". However, I think we should not soften this too much, and "strive to" already makes it a bit less strong, so perhaps just remove this?
Wasmtime GitHub notifications bot (Nov 18 2020 at 15:30):tschneidereit created PR Review Comment:
We should also have guidelines for whether features should be enabled by default at runtime, or require a flag to be set.
Maybe we can differentiate some of this by which stage in the process the proposal is in? Something like
- stage 0 proposals must be disabled by default at compile time, and must require a flag at runtime
- stage 1 proposals can be enabled by default, but must require a flag at runtime
- stage 2+ proposals can be enabled by default at compile and runtime
Wasmtime GitHub notifications bot (Nov 18 2020 at 15:30):tschneidereit created PR Review Comment:
Would it make sense to require these to have an RFC filed for them? I think that'd be good practice, and now that we're starting to actually use RFCs, it seems like there's not too much blocking that.
Wasmtime GitHub notifications bot (Nov 18 2020 at 15:30):tschneidereit created PR Review Comment:
An additional guideline might be about which namespace the API should be in. Perhaps stage 2+ can use the WASI namespacing system, but everything before some explicitly more experimental namespace? @sunfishcode and @pchickey, I'd be curious what your take is on this?
Wasmtime GitHub notifications bot (Nov 18 2020 at 17:53):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Nov 18 2020 at 17:53):abrown created PR Review Comment:
:+1: I discussed wasi-nn multiple times on Zulip and the Wasmtime meetings; an RFC would have hopefully recorded all of that in one place.
Wasmtime GitHub notifications bot (Nov 18 2020 at 18:03):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Nov 18 2020 at 18:19):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Nov 18 2020 at 18:19):pchickey created PR Review Comment:
Lets leave the namespace up to wherever the proposal is with in the WASI subgroup, but also permit an experimental namespace to be used by all proposals.
Wasmtime GitHub notifications bot (Nov 18 2020 at 18:19):pchickey edited PR Review Comment.
Wasmtime GitHub notifications bot (Nov 20 2020 at 12:23):tschneidereit submitted PR Review.
Wasmtime GitHub notifications bot (Nov 20 2020 at 12:23):tschneidereit created PR Review Comment:
Good point that this is a WASI subgroup topic more than anything else. So perhaps a more general statement could be included here around following the WASI subgroup's rules around exposure of in-progress proposals?
Wasmtime GitHub notifications bot (Nov 20 2020 at 17:24):alexcrichton updated PR #2423 from document-wasi-proposals to main:
I've attempted to summarize our thoughts from last week's meeting here
to jot down the suggested guidelines for adding a new WASI proposal to
this repository. I've also filled it out a bit with the two proposals we
support at this time.
Wasmtime GitHub notifications bot (Mar 14 2024 at 17:52):alexcrichton closed without merge PR #2423.
Wasmtime GitHub notifications bot (Mar 14 2024 at 17:52):alexcrichton commented on PR #2423:
This is quite out of date at this point, I'll push this up in the future if I get around to it with a rebase.
Last updated: Nov 22 2024 at 17:03 UTC