Stream: git-wasmtime

Topic: wasmtime / PR #2419 [WIP] Fixes #2418: Enhance wiggle to ...

Wasmtime GitHub notifications bot (Nov 13 2020 at 19:43):

fst-crenshaw opened PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [ ] This has been discussed in issue #2418.
• [ ] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 14 2020 at 01:44):

peterhuene requested pchickey for a review on PR #2419.

Wasmtime GitHub notifications bot (Nov 16 2020 at 18:31):

pchickey edited PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [ ] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 16 2020 at 18:32):

pchickey edited PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 16 2020 at 23:10):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 17 2020 at 00:06):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 17 2020 at 05:05):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 17 2020 at 05:26):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 01:04):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 03:12):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 03:29):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 07:30):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 19:31):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 19:36):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 19:41):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 19:42):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 19:43):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 20:00):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 20:10):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 21:02):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 21:07):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 21:11):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 22:18):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 22:50):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 23:02):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey

Wasmtime GitHub notifications bot (Nov 20 2020 at 23:13):

fst-crenshaw submitted PR Review.

Wasmtime GitHub notifications bot (Nov 20 2020 at 23:13):

fst-crenshaw created PR Review Comment:

I don't have experience with this combination of procedural macros and cargo fmt. Any advice here?

Wasmtime GitHub notifications bot (Nov 21 2020 at 03:15):

fst-crenshaw has marked PR #2419 as ready for review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton created PR Review Comment:

For referenced, I recommended this get removed since it needed to get updated anyway and I don't think that anything is using this right now.

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton created PR Review Comment:

I think the formatting here has gone awry?

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton created PR Review Comment:

I think the indentation here is a bit off?

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton created PR Review Comment:

FWIW this could also be:

match result {
    Ok(r) => Ok(r #cvt_ret),
    Err(err) => Err(wasmtime::Trap::new(err)),
}

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton created PR Review Comment:

Ah unfortunately cargo fmt ignores everything inside of procedural macros (since they're opaque as to what they're supposed to be), so we're left to manually format everything inside.

Wasmtime GitHub notifications bot (Nov 23 2020 at 15:16):

alexcrichton created PR Review Comment:

Out of curiosity is this functionality needed for anything in particular?

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:08):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:09):

fst-crenshaw submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:09):

fst-crenshaw created PR Review Comment:

Truth. Addressed in https://github.com/bytecodealliance/wasmtime/pull/2419/commits/6c717bf86cf7584aeaac694c3868298a0518c519

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:16):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:25):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:34):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:39):

fst-crenshaw submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 19:39):

fst-crenshaw created PR Review Comment:

Thanks! It's looking better now.

Wasmtime GitHub notifications bot (Nov 23 2020 at 21:35):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:35):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:41):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:43):

fst-crenshaw submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:43):

fst-crenshaw created PR Review Comment:

This was a point that @pchickey made while he and I were pairing on this. IIRC, his comment about it came from a place of wanting GuestErrorConversion to be consistent with the enhancement this PR makes to UserErrorConversion. That said, I don't think that this is needed for anything in particular at the moment. If it's alright with folks, I'd like to omit this TODO comment.

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:46):

fst-crenshaw submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:46):

fst-crenshaw created PR Review Comment:

I appreciate your patience @alexcrichton with all the formatting errors in this PR. I wasn't aware that cargo fmt ignores everything inside of proc macros. #life-long-learning.

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:47):

fst-crenshaw submitted PR Review.

Wasmtime GitHub notifications bot (Nov 23 2020 at 22:47):

fst-crenshaw created PR Review Comment:

Truth!

Wasmtime GitHub notifications bot (Nov 23 2020 at 23:17):

fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz to main:

_Long-time listener, first-time caller._

I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.

• [x] This has been introduced in issue #2418.
• [x] This PR contains refactored test cases.
• [x] This has been discussed in issue #2418.
• [x] Reviewer request: @pchickey
  

Wasmtime GitHub notifications bot (Nov 24 2020 at 15:05):

alexcrichton submitted PR Review.

Last updated: Nov 22 2024 at 16:03 UTC