fst-crenshaw opened PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [ ] This has been discussed in issue #2418.
- [ ] Reviewer request: @pchickey
peterhuene requested pchickey for a review on PR #2419.
pchickey edited PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [ ] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
pchickey edited PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw submitted PR Review.
fst-crenshaw created PR Review Comment:
I don't have experience with this combination of procedural macros and
cargo fmt
. Any advice here?
fst-crenshaw has marked PR #2419 as ready for review.
alexcrichton submitted PR Review.
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
For referenced, I recommended this get removed since it needed to get updated anyway and I don't think that anything is using this right now.
alexcrichton created PR Review Comment:
I think the formatting here has gone awry?
alexcrichton created PR Review Comment:
I think the indentation here is a bit off?
alexcrichton created PR Review Comment:
FWIW this could also be:
match result { Ok(r) => Ok(r #cvt_ret), Err(err) => Err(wasmtime::Trap::new(err)), }
alexcrichton created PR Review Comment:
Ah unfortunately
cargo fmt
ignores everything inside of procedural macros (since they're opaque as to what they're supposed to be), so we're left to manually format everything inside.
alexcrichton created PR Review Comment:
Out of curiosity is this functionality needed for anything in particular?
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw submitted PR Review.
fst-crenshaw created PR Review Comment:
Truth. Addressed in https://github.com/bytecodealliance/wasmtime/pull/2419/commits/6c717bf86cf7584aeaac694c3868298a0518c519
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw submitted PR Review.
fst-crenshaw created PR Review Comment:
Thanks! It's looking better now.
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
fst-crenshaw submitted PR Review.
fst-crenshaw created PR Review Comment:
This was a point that @pchickey made while he and I were pairing on this. IIRC, his comment about it came from a place of wanting GuestErrorConversion to be consistent with the enhancement this PR makes to UserErrorConversion. That said, I don't think that this is needed for anything in particular at the moment. If it's alright with folks, I'd like to omit this TODO comment.
fst-crenshaw submitted PR Review.
fst-crenshaw created PR Review Comment:
I appreciate your patience @alexcrichton with all the formatting errors in this PR. I wasn't aware that
cargo fmt
ignores everything inside of proc macros. #life-long-learning.
fst-crenshaw submitted PR Review.
fst-crenshaw created PR Review Comment:
Truth!
fst-crenshaw updated PR #2419 from tlc/enhance_with_trapz
to main
:
_Long-time listener, first-time caller._
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.
- [x] This has been introduced in issue #2418.
- [x] This PR contains refactored test cases.
- [x] This has been discussed in issue #2418.
- [x] Reviewer request: @pchickey
alexcrichton submitted PR Review.
Last updated: Dec 23 2024 at 12:05 UTC