Stream: git-wasmtime

Topic: wasmtime / PR #2413 Cranelift AArch64: Further vector con...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 13 2020 at 16:10):

akirilov-arm opened PR #2413 from fmov_vector to main:

Introduce support for MOVI/MVNI with 16-, 32-, and 64-bit elements, and the vector variant of FMOV.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 19:51):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 19:51):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 19:51):

cfallin created PR Review Comment:

Can we take a size enum here instead of a bool, for clarity?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 19:51):

cfallin created PR Review Comment:

I think I'd prefer to use the word "hint" here, since it seems that this is a correctness requirement (right?) -- eliding a move that actually serves a zero-extending purpose would result in bad results.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 19:51):

cfallin created PR Review Comment:

Alternately, could we turn the zeroing variant into an Extend variant, since that's functionally what it's doing?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 21:14):

jgouly submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 21:14):

jgouly created PR Review Comment:

If it does become an Extend, probably better if https://github.com/bytecodealliance/wasmtime/pull/2414 goes in first.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 16:32):

akirilov-arm updated PR #2413 from fmov_vector to main:

Introduce support for MOVI/MVNI with 16-, 32-, and 64-bit elements, and the vector variant of FMOV.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 16:34):

akirilov-arm submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 16:34):

akirilov-arm created PR Review Comment:

@cfallin I decided to add an Inst::FpuExtend variant because it felt cleaner.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 17:30):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 17:30):

cfallin created PR Review Comment:

This looks better for sure; thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 17:31):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2020 at 17:43):

cfallin merged PR #2413.

Last updated: Dec 23 2024 at 12:05 UTC