Stream: git-wasmtime

Topic: wasmtime / PR #2411 Don't run old x86 backend-specific te...

Wasmtime GitHub notifications bot (Nov 13 2020 at 04:49):

cfallin opened PR #2411 from x86-backend-cfg to main:

Some of the test failures tracked by #2079 are in unwind tests that are
specific to the old x86 backend: namely, these tests invoke the unwind
implementation that is paired with the old backend, rather than generic
over all backends. It thus doesn't make sense to try to run these tests
with the new backend. (The new backend's unwind code should have
analogous tests written/ported over eventually.)

It seems that we were actually building both x86 backends when the
x64 feature was enabled, except that the old x86 backend would never
be instantiated by the usual ISA-lookup logic because a x86-64 target
triple unconditionally resolves to the new one.

This PR resolves both of the issues by tweaking the feature-config
directives to exclude the x86 backend when x64 is enabled.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 13 2020 at 04:49):

cfallin requested abrown for a review on PR #2411.

Wasmtime GitHub notifications bot (Nov 13 2020 at 17:03):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Nov 13 2020 at 17:29):

cfallin merged PR #2411.

Last updated: Nov 22 2024 at 17:03 UTC