Stream: git-wasmtime

Topic: wasmtime / PR #2410 Fix and enable GC on new x64 backend.

Wasmtime GitHub notifications bot (Nov 13 2020 at 01:03):

cfallin requested fitzgen for a review on PR #2410.

Wasmtime GitHub notifications bot (Nov 13 2020 at 01:03):

cfallin opened PR #2410 from x64-gc to main:

One critical bit of plumbing was missing: the StackMapSink passed to
compile_and_emit was not actually receiving stackmaps. This seemingly
very basic issue was not caught because the other major user of reftype
support, SpiderMonkey, extracts stackmaps with a lower-level API. The
SM integration was built this way to avoid an awkward API quirk when
passing stackmaps through a CodeSink that proxies them to a
StackMapSink: the CodeSink wants Values for each reference slot,
while the actual StackMapSink does not require these. This PR tweaks
the plumbing in a slightly different way to make wasmtime GC tests,
and presumably other consumers of stack-map info from the top-level
Cranelift interface, happy.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 13 2020 at 15:19):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Nov 13 2020 at 17:40):

cfallin merged PR #2410.

Last updated: Nov 22 2024 at 16:03 UTC