Stream: git-wasmtime

Topic: wasmtime / PR #2400 Specify unsealed / unfilled blocks


view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2020 at 04:35):

MattX opened PR #2400 from improve-finalize-msg to main:

Hello! I'm suggesting this quick change that's helped me with debugging. Required information below.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2020 at 04:35):

MattX updated PR #2400 from improve-finalize-msg to main:

Hello! I'm suggesting this quick change that's helped me with debugging. Required information below.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2020 at 04:38):

MattX edited PR #2400 from improve-finalize-msg to main:

Hello! I'm suggesting this quick change that's helped me with debugging. Required information below.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 00:59):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2020 at 21:22):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2020 at 21:22):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2020 at 21:22):

fitzgen created PR Review Comment:

We can make this a little less word-y by using assert! instead of if and panci!:

                assert!(
                    block_data.pristine || self.func_ctx.ssa.is_sealed(block),
                    "FunctionBuilder finalized, but block {} is not sealed",
                    block,
                );
                assert!(
                    block_data.pristine || block_data.filled,
                    "FunctionBuilder finalized, but block {} is not filled",
                    block,
                );

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2020 at 05:03):

MattX updated PR #2400 from improve-finalize-msg to main:

Hello! I'm suggesting this quick change that's helped me with debugging. Required information below.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2020 at 16:45):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2020 at 16:45):

fitzgen merged PR #2400.


Last updated: Dec 23 2024 at 13:07 UTC