Stream: git-wasmtime

Topic: wasmtime / PR #2391 Support wasm `select` instruction wit...

Wasmtime GitHub notifications bot (Nov 11 2020 at 16:12):

julian-seward1 opened PR #2391 from arm64-select-v128 to main:

• this requires upgrading to wasmparser 0.67.0.

• There are no CLIF side changes because the CLIF select instruction is
  polymorphic enough.

• on aarch64, there is unfortunately no conditional-move (csel) instruction on
  vectors. This patch adds a synthetic instruction VecCSel which does
  behave like that. At emit time, this is emitted as an if-then-else diamond
  (4 insns).

• aarch64 implementation is otherwise straightforwards.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 11 2020 at 16:37):

julian-seward1 requested yurydelendik for a review on PR #2391.

Wasmtime GitHub notifications bot (Nov 11 2020 at 17:05):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Nov 11 2020 at 17:05):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Nov 11 2020 at 17:05):

yurydelendik created PR Review Comment:

Just to note, it is weird to see that ctx.emit(Inst::CSel ... below did not have assert to prevent float/128 to become csel.

Wasmtime GitHub notifications bot (Nov 11 2020 at 17:09):

julian-seward1 updated PR #2391 from arm64-select-v128 to main:

• this requires upgrading to wasmparser 0.67.0.

• There are no CLIF side changes because the CLIF select instruction is
  polymorphic enough.

• on aarch64, there is unfortunately no conditional-move (csel) instruction on
  vectors. This patch adds a synthetic instruction VecCSel which does
  behave like that. At emit time, this is emitted as an if-then-else diamond
  (4 insns).

• aarch64 implementation is otherwise straightforwards.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 11 2020 at 17:45):

julian-seward1 merged PR #2391.

Last updated: Nov 22 2024 at 16:03 UTC