Wasmtime GitHub notifications bot (Nov 10 2020 at 17:38): Wasmtime GitHub notifications bot (Nov 10 2020 at 17:38):Voultapher opened PR #2387 from fix-min-rust-version to main:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.<!--
Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Wasmtime GitHub notifications bot (Nov 10 2020 at 17:39):Voultapher edited PR #2387 from fix-min-rust-version to main:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Wasmtime GitHub notifications bot (Nov 10 2020 at 18:30):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Nov 10 2020 at 18:30):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Nov 10 2020 at 18:30):cfallin created PR Review Comment:
Could we say something like: "Building all crates in the wasmtime + Cranelift repository will require a nightly version of Rust. With stable Rust, one can build the
wasmtimebinary (cargo buildin the repository root) and theclif-utilbinary (cargo build -p cranelift-tools). Core Cranelift cratescranelift-codegen,cranelift-wasmand their dependencies will build on stable Rust."? In other words, I don't want to give the impression that nothing at all is usable without nightly.Also should we say something about our goals? IIRC @alexcrichton had a related PR recently. Are we working toward only using stable Rust eventually or will we always have some nightly-only crates?
Wasmtime GitHub notifications bot (Nov 10 2020 at 18:49):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Nov 10 2020 at 18:49):bjorn3 created PR Review Comment:
Lightbeam was ported to stable in https://github.com/bytecodealliance/wasmtime/pull/2370. I don't think there were any other crates that require nightly.
Wasmtime GitHub notifications bot (Nov 11 2020 at 07:45):Voultapher updated PR #2387 from fix-min-rust-version to main:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Wasmtime GitHub notifications bot (Nov 11 2020 at 15:27):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Nov 11 2020 at 15:27):alexcrichton created PR Review Comment:
I think we don't have anything at this point that requires nightly, so this may need to be updated?
Wasmtime GitHub notifications bot (Nov 11 2020 at 20:40):Voultapher submitted PR Review.
Wasmtime GitHub notifications bot (Nov 11 2020 at 20:40):Voultapher created PR Review Comment:
I suggest a small experiment to check your assumption:
- clean clone
- cargo test --all with stable rust
I've tried this and it complains about feature(test) being nightly only.
Wasmtime GitHub notifications bot (Nov 11 2020 at 20:45):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Nov 11 2020 at 20:45):bjorn3 created PR Review Comment:
Lightbeam uses an unstable feature for benchmarks: https://github.com/bytecodealliance/wasmtime/blob/d2daf5064e5ee2f1c630579e4c6e273a5a504d3c/crates/lightbeam/src/lib.rs#L1
Simply building doesn't use this, only when testing the lightbeam crate is it used.
Wasmtime GitHub notifications bot (Nov 11 2020 at 22:09):alexcrichton created PR Review Comment:
Wasmtime is a big repository and has a lot of projects in it. Mentioning very prominently inthe README that the whole project requires nightly because of one optional dependency only for tests feels a bit disingenuous which is why I think this should be reworded a bit.
Wasmtime GitHub notifications bot (Nov 11 2020 at 22:09):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Nov 12 2020 at 07:30):Voultapher updated PR #2387 from fix-min-rust-version to main:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Wasmtime GitHub notifications bot (Nov 12 2020 at 07:31):Voultapher submitted PR Review.
Wasmtime GitHub notifications bot (Nov 12 2020 at 07:31):Voultapher created PR Review Comment:
Fair, I adjusted it to better reflect this notion. Note this the cranelift README not the top level one.
Wasmtime GitHub notifications bot (Nov 12 2020 at 07:42):bjorn3 created PR Review Comment:
Not for Cranelift, only Wasmtime. Lightbeam is a part of Wasmtime. I haven't ever used nightly rustc to work on Cranelift.
Wasmtime GitHub notifications bot (Nov 12 2020 at 07:42):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Nov 12 2020 at 16:34):Voultapher updated PR #2387 from fix-min-rust-version to main:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Wasmtime GitHub notifications bot (Jun 03 2021 at 11:54):Voultapher closed without merge PR #2387.
Last updated: Nov 22 2024 at 17:03 UTC