Voultapher opened PR #2387 from fix-min-rust-version
to main
:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.<!--
Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Voultapher edited PR #2387 from fix-min-rust-version
to main
:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
cfallin submitted PR Review.
cfallin submitted PR Review.
cfallin created PR Review Comment:
Could we say something like: "Building all crates in the wasmtime + Cranelift repository will require a nightly version of Rust. With stable Rust, one can build the
wasmtime
binary (cargo build
in the repository root) and theclif-util
binary (cargo build -p cranelift-tools
). Core Cranelift cratescranelift-codegen
,cranelift-wasm
and their dependencies will build on stable Rust."? In other words, I don't want to give the impression that nothing at all is usable without nightly.Also should we say something about our goals? IIRC @alexcrichton had a related PR recently. Are we working toward only using stable Rust eventually or will we always have some nightly-only crates?
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
Lightbeam was ported to stable in https://github.com/bytecodealliance/wasmtime/pull/2370. I don't think there were any other crates that require nightly.
Voultapher updated PR #2387 from fix-min-rust-version
to main
:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
I think we don't have anything at this point that requires nightly, so this may need to be updated?
Voultapher submitted PR Review.
Voultapher created PR Review Comment:
I suggest a small experiment to check your assumption:
- clean clone
- cargo test --all with stable rust
I've tried this and it complains about feature(test) being nightly only.
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
Lightbeam uses an unstable feature for benchmarks: https://github.com/bytecodealliance/wasmtime/blob/d2daf5064e5ee2f1c630579e4c6e273a5a504d3c/crates/lightbeam/src/lib.rs#L1
Simply building doesn't use this, only when testing the lightbeam crate is it used.
alexcrichton created PR Review Comment:
Wasmtime is a big repository and has a lot of projects in it. Mentioning very prominently inthe README that the whole project requires nightly because of one optional dependency only for tests feels a bit disingenuous which is why I think this should be reworded a bit.
alexcrichton submitted PR Review.
Voultapher updated PR #2387 from fix-min-rust-version
to main
:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Voultapher submitted PR Review.
Voultapher created PR Review Comment:
Fair, I adjusted it to better reflect this notion. Note this the cranelift README not the top level one.
bjorn3 created PR Review Comment:
Not for Cranelift, only Wasmtime. Lightbeam is a part of Wasmtime. I haven't ever used nightly rustc to work on Cranelift.
bjorn3 submitted PR Review.
Voultapher updated PR #2387 from fix-min-rust-version
to main
:
This removes the Rust 1.37 badge which is no longer correct,
and in lack of an automated system will become outdated again.
The more reliable strategy is to not document this information.This also documents that in order to build cranelift a nightly
version of the Rust is required.Fixes issue #2377
I don't know if this change is complete, I'm not familiar with the topology of this project and acted on a broad suggestion.
Voultapher closed without merge PR #2387.
Last updated: Dec 23 2024 at 13:07 UTC