Wasmtime GitHub notifications bot (Nov 09 2020 at 16:25): Wasmtime GitHub notifications bot (Nov 09 2020 at 16:25):uweigand opened PR #2383 from endian-guesttype to main:
The GuestType trait is used to access data elements in guest memory.
According to the WebAssembly spec, those are always stored in
little-endian byte order, even on big-endian hosts. Accessing such
elements on big-endian hosts therefore requires byte swapping.Fixed by adding from_le_bytes / to_le_bytes.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:33):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:33):alexcrichton created PR Review Comment:
Instead of using
[u8; ...]could thefrom_leandto_lemethods be used?
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:34):uweigand submitted PR Review.
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:34):uweigand created PR Review Comment:
I think when I tried those, they failed for f32 and f64 types.
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:36):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:36):alexcrichton created PR Review Comment:
Ah yeah that'd do it!
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:36):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Nov 09 2020 at 16:59):alexcrichton merged PR #2383.
Last updated: Oct 23 2024 at 20:03 UTC