Stream: git-wasmtime

Topic: wasmtime / PR #2382 Support building big-endian objects


view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2020 at 16:24):

uweigand opened PR #2382 from endian-object to main:

The JIT build_object routine currently rejects building object files
for any big-endian platform. However, most of the object builder
code works fine for either byte order, with the exception of a small
change in the ObjectBuilderTarget::new routine.

This patch adds that change and removes the assert in build_object.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2020 at 16:35):

uweigand updated PR #2382 from endian-object to main:

The JIT build_object routine currently rejects building object files
for any big-endian platform. However, most of the object builder
code works fine for either byte order, with the exception of a small
change in the ObjectBuilderTarget::new routine.

This patch adds that change and removes the assert in build_object.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2020 at 17:19):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2020 at 17:19):

alexcrichton merged PR #2382.


Last updated: Dec 23 2024 at 12:05 UTC