Stream: git-wasmtime

Topic: wasmtime / PR #2371 Allow offloading compilation in crane...

Wasmtime GitHub notifications bot (Nov 05 2020 at 21:11):

alexcrichton opened PR #2371 from parallelize-module to main:

This commit is a slight refactoring of the Module trait and backend in
cranelift-object. The goal is to enable parallelization of compilation
when using cranelift-object. Currently this is difficult because
ObjectModule::define_function requires &mut self. This instead
soups up the define_function_bytes interface to handle relocations so
compilation can happen externally before defining it in a Module. This
also means that define_function is now a convenience wrapper around
define_function_bytes.

Wasmtime GitHub notifications bot (Nov 05 2020 at 21:11):

alexcrichton requested pchickey for a review on PR #2371.

Wasmtime GitHub notifications bot (Nov 05 2020 at 21:23):

alexcrichton updated PR #2371 from parallelize-module to main:

This commit is a slight refactoring of the Module trait and backend in
cranelift-object. The goal is to enable parallelization of compilation
when using cranelift-object. Currently this is difficult because
ObjectModule::define_function requires &mut self. This instead
soups up the define_function_bytes interface to handle relocations so
compilation can happen externally before defining it in a Module. This
also means that define_function is now a convenience wrapper around
define_function_bytes.

Wasmtime GitHub notifications bot (Nov 05 2020 at 21:26):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 21:26):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 21:26):

bjorn3 created PR Review Comment:

I think the tuple should be a new type. I think cranelift-simplejit already has a type for this.

Wasmtime GitHub notifications bot (Nov 06 2020 at 15:19):

alexcrichton updated PR #2371 from parallelize-module to main:

This commit is a slight refactoring of the Module trait and backend in
cranelift-object. The goal is to enable parallelization of compilation
when using cranelift-object. Currently this is difficult because
ObjectModule::define_function requires &mut self. This instead
soups up the define_function_bytes interface to handle relocations so
compilation can happen externally before defining it in a Module. This
also means that define_function is now a convenience wrapper around
define_function_bytes.

Wasmtime GitHub notifications bot (Nov 06 2020 at 15:19):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Nov 06 2020 at 15:19):

alexcrichton created PR Review Comment:

Seems reasonable to me!

Wasmtime GitHub notifications bot (Nov 06 2020 at 15:56):

alexcrichton merged PR #2371.

Last updated: Dec 23 2024 at 12:05 UTC