Stream: git-wasmtime

Topic: wasmtime / PR #2365 Store `WasmFuncType` in `FuncType`

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:24):

alexcrichton opened PR #2365 from tweak-func-type to main:

This commit updates wasmtime::FuncType to exactly store an internal
WasmFuncType from the cranelift crates. This allows us to remove a
translation layer when we are given a FuncType and want to get an
internal cranelift type out as a result.

The other major change from this commit was changing the constructor and
accessors of FuncType to be iterator-based instead of exposing
implementation details.

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:24):

alexcrichton requested fitzgen for a review on PR #2365.

Wasmtime GitHub notifications bot (Nov 04 2020 at 22:04):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 05:24):

alexcrichton updated PR #2365 from tweak-func-type to main:

This commit updates wasmtime::FuncType to exactly store an internal
WasmFuncType from the cranelift crates. This allows us to remove a
translation layer when we are given a FuncType and want to get an
internal cranelift type out as a result.

The other major change from this commit was changing the constructor and
accessors of FuncType to be iterator-based instead of exposing
implementation details.

Wasmtime GitHub notifications bot (Nov 05 2020 at 05:49):

alexcrichton updated PR #2365 from tweak-func-type to main:

This commit updates wasmtime::FuncType to exactly store an internal
WasmFuncType from the cranelift crates. This allows us to remove a
translation layer when we are given a FuncType and want to get an
internal cranelift type out as a result.

The other major change from this commit was changing the constructor and
accessors of FuncType to be iterator-based instead of exposing
implementation details.

Wasmtime GitHub notifications bot (Nov 05 2020 at 14:49):

alexcrichton merged PR #2365.

Last updated: Dec 23 2024 at 12:05 UTC