Stream: git-wasmtime

Topic: wasmtime / PR #2364 peepmatic: Make the test-we-can-get-a...

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:04):

fitzgen opened PR #2364 from peepmatic-rebuild-test to main:

This change means that running

cargo test --features "enable-peepmatic rebuild-peephole-optimizers"

inside cranelift/codegen will rebuild peephole optimizers on not only x86_64
but also aarch64.

@julian-seward1 can you verify that with this commit applied, you can rebuild preopt.serialized okay on aarch64? Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 03 2020 at 22:37):

fitzgen requested abrown for a review on PR #2364.

Wasmtime GitHub notifications bot (Dec 04 2020 at 04:31):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Dec 04 2020 at 18:32):

fitzgen merged PR #2364.

Last updated: Oct 23 2024 at 20:03 UTC