Stream: git-wasmtime

Topic: wasmtime / PR #2362 Move native signatures out of `Module`

Wasmtime GitHub notifications bot (Nov 04 2020 at 19:22):

alexcrichton requested fitzgen for a review on PR #2362.

Wasmtime GitHub notifications bot (Nov 04 2020 at 19:22):

alexcrichton opened PR #2362 from less-native-sig to main:

After compilation there's actually no need to hold onto the native
signature for a wasm function type, so this commit moves out the
ir::Signature value from a Module into a separate field that's
deallocated when compilation is finished. This simplifies the
SignatureRegistry because it only needs to track wasm functino types
and it also means less work is done for Func::wrap.

Wasmtime GitHub notifications bot (Nov 04 2020 at 19:35):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Nov 04 2020 at 19:46):

alexcrichton updated PR #2362 from less-native-sig to main:

After compilation there's actually no need to hold onto the native
signature for a wasm function type, so this commit moves out the
ir::Signature value from a Module into a separate field that's
deallocated when compilation is finished. This simplifies the
SignatureRegistry because it only needs to track wasm functino types
and it also means less work is done for Func::wrap.

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:22):

alexcrichton merged PR #2362.

Last updated: Oct 23 2024 at 20:03 UTC