Wasmtime GitHub notifications bot (Nov 03 2020 at 15:27): Wasmtime GitHub notifications bot (Nov 03 2020 at 15:27):uweigand opened PR #2354 from fix-builtinuext to main:
Some platform ABIs require i32 values to be zero- or sign-extended
to the full register width. The extension is implemented by the
cranelift codegen backend, but this happens only if the appropriate
"uext" or "sext" attribute is present in the cranelift IR.For calls to builtin functions, that IR is synthesized by the code
in func_environ.rs -- to ensure correct codegen for the target ABI,
this code needs to add those attributes as necessary.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 12 2020 at 20:27):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Nov 12 2020 at 20:27):cfallin merged PR #2354.
Last updated: Nov 22 2024 at 17:03 UTC