Stream: git-wasmtime

Topic: wasmtime / PR #2352 x64 new-backend CI: use `Cargo.lock` ...

Wasmtime GitHub notifications bot (Nov 02 2020 at 19:17):

cfallin requested alexcrichton for a review on PR #2352.

Wasmtime GitHub notifications bot (Nov 02 2020 at 19:17):

cfallin opened PR #2352 from x64-ci-lock to main:

We do a cargo fetch --locked for most of our CI builds, but
run-experimental-x64-ci.sh was not doing this. As a result, some CI
runs seem to fail depending on which versions of crates they download. A
common failure mode is that two different versions of the syn crate
get into the build somehow, resulting in errors in wiggle/witx.

This change simply adds the --locked flag to the cargo test run for
the new x64 backend.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 02 2020 at 19:43):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Nov 02 2020 at 19:59):

cfallin merged PR #2352.

Last updated: Nov 22 2024 at 16:03 UTC