Stream: git-wasmtime

Topic: wasmtime / PR #2350 Fix a panic in table-ops translation

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 15:45):

alexcrichton opened PR #2350 from fix-panic to main:

This fixes an issue where ensure_inserted_block() wasn't called before
we do some block manipulation in the Wasmtime translation of some
table-related instructions. It looks like ensure_inserted_block() is
otherwise called on most instructions being added, so we just need to
call it explicitly it seems here.

Closes #2347

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 17:19):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 17:27):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 17:34):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 17:35):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 23:24):

alexcrichton updated PR #2350 from fix-panic to main:

This fixes an issue where ensure_inserted_block() wasn't called before
we do some block manipulation in the Wasmtime translation of some
table-related instructions. It looks like ensure_inserted_block() is
otherwise called on most instructions being added, so we just need to
call it explicitly it seems here.

Closes #2347

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2020 at 23:53):

alexcrichton merged PR #2350.

Last updated: Nov 22 2024 at 16:03 UTC