Wasmtime GitHub notifications bot (Nov 02 2020 at 12:20): Wasmtime GitHub notifications bot (Nov 02 2020 at 12:20):uweigand opened PR #2345 from abi-stackalign to main:
The common gen_prologue code currently assumes that the stack
pointer has to be aligned to twice the word size. While this
is true for many ABIs, it does not hold universally.This patch adds a new constant STACK_ALIGN that back-ends can
provide to define the specific stack alignment required by the
ABI on that platform.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 02 2020 at 12:21):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Nov 02 2020 at 12:21):bjorn3 created PR Review Comment:
I think this should be a regular function accepting a
CallConvargument.
Wasmtime GitHub notifications bot (Nov 02 2020 at 13:37):uweigand updated PR #2345 from abi-stackalign to main:
The common gen_prologue code currently assumes that the stack
pointer has to be aligned to twice the word size. While this
is true for many ABIs, it does not hold universally.This patch adds a new constant STACK_ALIGN that back-ends can
provide to define the specific stack alignment required by the
ABI on that platform.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 02 2020 at 13:38):uweigand submitted PR Review.
Wasmtime GitHub notifications bot (Nov 02 2020 at 13:38):uweigand created PR Review Comment:
Makes sense to me. I've updated the patch accordingly.
Wasmtime GitHub notifications bot (Nov 02 2020 at 19:00):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Nov 03 2020 at 08:44):uweigand updated PR #2345 from abi-stackalign to main:
The common gen_prologue code currently assumes that the stack
pointer has to be aligned to twice the word size. While this
is true for many ABIs, it does not hold universally.This patch adds a new constant STACK_ALIGN that back-ends can
provide to define the specific stack alignment required by the
ABI on that platform.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 03 2020 at 17:02):cfallin merged PR #2345.
Last updated: Dec 23 2024 at 12:05 UTC