Stream: git-wasmtime

Topic: wasmtime / PR #2343 Fix icmp_imm.i128

Wasmtime GitHub notifications bot (Oct 31 2020 at 18:24):

bjorn3 opened PR #2343 from fix_icmp_imm_i128 to main:

The immediate splitting code contained a bug causing both low and high
to be equal for i128. This is the root cause for
bjorn3/rustc_codegen_cranelift#1097 and likely the only bug preventing
cg_clif from bootstrapping rustc.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 31 2020 at 19:20):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Oct 31 2020 at 19:20):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Oct 31 2020 at 19:20):

cfallin created PR Review Comment:

Do we need to mask this as well? imm is an i64, and so a right-shift is an arithmetic right-shift that replicates the MSB on the left; a quick test shows that -1i64 >> 32 is still -1i64 (i.e., all ones).

Wasmtime GitHub notifications bot (Oct 31 2020 at 19:39):

bjorn3 updated PR #2343 from fix_icmp_imm_i128 to main:

The immediate splitting code contained a bug causing both low and high
to be equal for i128. This is the root cause for
bjorn3/rustc_codegen_cranelift#1097 and likely the only bug preventing
cg_clif from bootstrapping rustc.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 31 2020 at 19:41):

bjorn3 updated PR #2343 from fix_icmp_imm_i128 to main:

The immediate splitting code contained a bug causing both low and high
to be equal for i128. This is the root cause for
bjorn3/rustc_codegen_cranelift#1097 and likely the only bug preventing
cg_clif from bootstrapping rustc.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 31 2020 at 20:11):

bjorn3 updated PR #2343 from fix_icmp_imm_i128 to main:

The immediate splitting code contained a bug causing both low and high
to be equal for i128. This is the root cause for
bjorn3/rustc_codegen_cranelift#1097 and likely the only bug preventing
cg_clif from bootstrapping rustc.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 31 2020 at 20:12):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 31 2020 at 20:12):

bjorn3 created PR Review Comment:

Fixed

Wasmtime GitHub notifications bot (Oct 31 2020 at 20:18):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Oct 31 2020 at 21:09):

cfallin merged PR #2343.

Last updated: Dec 23 2024 at 12:05 UTC